Make GetDismissedSuggestionsForDebugging asynchronous

chrome/browser/ui/webui/snippets_internals_message_handler.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_SNIPPETS_INTERNALS_MESSAGE_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_SNIPPETS_INTERNALS_MESSAGE_HANDLER_H_
 
+#include <map>
 #include <string>
+#include <vector>
 
 #include "base/macros.h"
 #include "base/scoped_observer.h"
 #include "components/ntp_snippets/category.h"
 #include "components/ntp_snippets/category_status.h"
 #include "components/ntp_snippets/content_suggestions_service.h"
 #include "components/ntp_snippets/ntp_snippets_service.h"
 #include "content/public/browser/web_ui_message_handler.h"
 
 namespace base {
 class ListValue;
 }  // namespace base
 
 // The implementation for the chrome://snippets-internals page.
 class SnippetsInternalsMessageHandler
     : public content::WebUIMessageHandler,
       public ntp_snippets::ContentSuggestionsService::Observer {
  public:
   SnippetsInternalsMessageHandler();
   ~SnippetsInternalsMessageHandler() override;
 
  private:
+  enum class DismissedState { HIDDEN, LOADING, VISIBLE };
+
   // content::WebUIMessageHandler:
   void RegisterMessages() override;
 
   // ntp_snippets::ContentSuggestionsService::Observer:
   void OnNewSuggestions(ntp_snippets::Category category) override;
   void OnCategoryStatusChanged(
       ntp_snippets::Category category,
       ntp_snippets::CategoryStatus new_status) override;
   void OnSuggestionInvalidated(ntp_snippets::Category category,
                                const std::string& suggestion_id) override;
   void ContentSuggestionsServiceShutdown() override;
 
   void HandleRefreshContent(const base::ListValue* args);
   void HandleDownload(const base::ListValue* args);
   void HandleClearCachedSuggestions(const base::ListValue* args);
   void HandleClearDismissedSuggestions(const base::ListValue* args);
+  void HandleToggleDismissedSuggestions(const base::ListValue* args);
 
   void SendAllContent();
   void SendHosts();
   void SendContentSuggestions();
   void SendBoolean(const std::string& name, bool value);
   void SendString(const std::string& name, const std::string& value);
 
+  void OnDismissedSuggestionsLoaded(
+      ntp_snippets::Category category,
+      std::vector<ntp_snippets::ContentSuggestion> dismissed_suggestions);
+
   ScopedObserver<ntp_snippets::ContentSuggestionsService,
                  ntp_snippets::ContentSuggestionsService::Observer>
       content_suggestions_service_observer_;
 
   // Tracks whether we can already send messages to the page.
   bool dom_loaded_;
 
   ntp_snippets::NTPSnippetsService* ntp_snippets_service_;
   ntp_snippets::ContentSuggestionsService* content_suggestions_service_;
 
+  std::map<ntp_snippets::Category,
+           DismissedState,
+           ntp_snippets::Category::CompareByID>
+      dismissed_state_;
+  std::map<ntp_snippets::Category,
+           std::vector<ntp_snippets::ContentSuggestion>,
+           ntp_snippets::Category::CompareByID>
+      dismissed_suggestions_;

[Marc Treib, 2016/08/19 10:07:51]

Maybe make a struct that contains DismissedState and the vector of suggestions,
then you'd need only one map?

[Philipp Keck, 2016/08/19 12:11:53]

Not sure that would help readability (except if it has a great name, but I
couldn't come up with one) or lead to less code.

+
   DISALLOW_COPY_AND_ASSIGN(SnippetsInternalsMessageHandler);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_SNIPPETS_INTERNALS_MESSAGE_HANDLER_H_