Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-3.html

Issue 2260763002: Convert LayoutTests/svg/text/* js-tests.js tests to testharness.js based tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Align with review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-3.html
diff --git a/third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-3.html b/third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-3.html
index 7148850f8d6aad298bd66051059444f29b30ff82..f59eac9fbff82c0ee0d46088b7bf2b8753e16755 100644
--- a/third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-3.html
+++ b/third_party/WebKit/LayoutTests/svg/text/selection-dragging-outside-3.html
@@ -15,28 +15,22 @@ text {
</g>
</g>
</svg>
-<script src="../../resources/js-test.js"></script>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
<script src="resources/SelectionTestCase.js"></script>
-<script type="text/javascript">
-function getEndPosition(id, offset, gap) {
- var element = document.getElementById(id);
- var endPos = element.getEndPositionOfChar(offset);
- endPos.x += gap.x;
- endPos.y += gap.y;
- var absEndPos = toAbsoluteCoordinates(endPos, element);
- return absEndPos;
-}
-
-var absEndPos = getEndPosition('line1', 10, { x : 0, y : -20});
-selectTextFromCharToPoint({ id: 'line1', offset: 0 }, absEndPos, { startElementId: "line1", start: "0", endElementId: "line1", end: "11" });
-absEndPos = getEndPosition('line1', 23, { x : 0, y : -20});
-selectTextFromCharToPoint({ id: 'line1', offset: 7 }, absEndPos, { startElementId: "line1", start: "7", endElementId: "line1", end: "24" });
-absEndPos = getEndPosition('line2', 10, { x : 0, y : 20});
-selectTextFromCharToPoint({ id: 'line2', offset: 0 }, absEndPos, { startElementId: "line2", start: "0", endElementId: "line2", end: "11" });
-absEndPos = getEndPosition('line2', 23, { x : 0, y : 20});
-selectTextFromCharToPoint({ id: 'line2', offset: 7 }, absEndPos, { startElementId: "line2", start: "7", endElementId: "line2", end: "24" });
-absEndPos = getEndPosition('line2', 10, { x : 0, y : 20});
-selectTextFromCharToPoint({ id: 'line1', offset: 7 }, absEndPos, { startElementId: "line1", start: "7", endElementId: "line2", end: "11" });
-absEndPos = getEndPosition('line1', 20, { x : 0, y : -20});
-selectTextFromCharToPoint({ id: 'line2', offset: 7 }, absEndPos, { startElementId: "line2", start: "7", endElementId: "line1", end: "21" });
+<script>
+test(function() {
+ var absEndPos = getEndPosition('line1', 10, { x : 0, y : -20});
+ selectTextFromCharToPoint({ id: 'line1', offset: 0 }, absEndPos, { startElementId: "line1", start: 0, endElementId: "line1", end: 11 });
+ absEndPos = getEndPosition('line1', 23, { x : 0, y : -20});
+ selectTextFromCharToPoint({ id: 'line1', offset: 7 }, absEndPos, { startElementId: "line1", start: 7, endElementId: "line1", end: 24 });
+ absEndPos = getEndPosition('line2', 10, { x : 0, y : 20});
+ selectTextFromCharToPoint({ id: 'line2', offset: 0 }, absEndPos, { startElementId: "line2", start: 0, endElementId: "line2", end: 11 });
+ absEndPos = getEndPosition('line2', 23, { x : 0, y : 20});
+ selectTextFromCharToPoint({ id: 'line2', offset: 7 }, absEndPos, { startElementId: "line2", start: 7, endElementId: "line2", end: 24 });
+ absEndPos = getEndPosition('line2', 10, { x : 0, y : 20});
+ selectTextFromCharToPoint({ id: 'line1', offset: 7 }, absEndPos, { startElementId: "line1", start: 7, endElementId: "line2", end: 11 });
+ absEndPos = getEndPosition('line1', 20, { x : 0, y : -20});
+ selectTextFromCharToPoint({ id: 'line2', offset: 7 }, absEndPos, { startElementId: "line2", start: 7, endElementId: "line1", end: 21 });
+});
fs 2016/08/22 14:10:05 Ditto.
Shanmuga Pandi 2016/08/23 07:11:38 Done.
</script>

Powered by Google App Engine
This is Rietveld 408576698