Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Side by Side Diff: scripts/slave/recipe_modules/isolate/api.py

Issue 2260733002: Use files in path['checkout'] not resource. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: updated *.json Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from recipe_engine import recipe_api 5 from recipe_engine import recipe_api
6 6
7 7
8 class IsolateApi(recipe_api.RecipeApi): 8 class IsolateApi(recipe_api.RecipeApi):
9 """APIs for interacting with isolates.""" 9 """APIs for interacting with isolates."""
10 10
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 ] 200 ]
201 if args: 201 if args:
202 cmd.append('--') 202 cmd.append('--')
203 cmd.extend(args) 203 cmd.extend(args)
204 self.m.python(name, self._run_isolated_path, cmd, **kwargs) 204 self.m.python(name, self._run_isolated_path, cmd, **kwargs)
205 205
206 def remove_build_metadata(self): 206 def remove_build_metadata(self):
207 """Removes the build metadata embedded in the build artifacts.""" 207 """Removes the build metadata embedded in the build artifacts."""
208 args = [ 208 args = [
209 '--build-dir', self.m.chromium.output_dir, 209 '--build-dir', self.m.chromium.output_dir,
210 '--src-dir', self.m.path['checkout']
211 ] 210 ]
212 # Turn the failures during this step into warnings, it's a best effort step 211 # Turn the failures during this step into warnings, it's a best effort step
213 # that shouldn't break the build for now. 212 # that shouldn't break the build for now.
214 try: 213 try:
215 self.m.python('remove_build_metadata', 214 self.m.python('remove_build_metadata',
216 self.resource('remove_build_metadata.py'), 215 self.m.path.join(self.m.path['checkout'],
216 'tools',
217 'determinism',
218 'remove_build_metadata.py'),
217 args=args, 219 args=args,
218 cwd=self.m.path['slave_build']) 220 cwd=self.m.path['slave_build'])
219 except self.m.step.StepFailure: 221 except self.m.step.StepFailure:
220 step_result = self.m.step.active_result 222 step_result = self.m.step.active_result
221 step_result.presentation.status = self.m.step.WARNING 223 step_result.presentation.status = self.m.step.WARNING
222 224
223 def compare_build_artifacts(self, first_dir, second_dir): 225 def compare_build_artifacts(self, first_dir, second_dir):
224 """Compare the artifacts from 2 builds.""" 226 """Compare the artifacts from 2 builds."""
225 args = [ 227 args = [
226 '--first-build-dir', first_dir, 228 '--first-build-dir', first_dir,
227 '--second-build-dir', second_dir, 229 '--second-build-dir', second_dir,
228 '--target-platform', self.m.chromium.c.TARGET_PLATFORM 230 '--target-platform', self.m.chromium.c.TARGET_PLATFORM
229 ] 231 ]
230 self.m.python('compare_build_artifacts', 232 self.m.python('compare_build_artifacts',
231 self.resource('compare_build_artifacts.py'), 233 self.m.path.join(self.m.path['checkout'],
234 'tools',
235 'determinism',
236 'compare_build_artifacts.py'),
232 args=args, 237 args=args,
233 cwd=self.m.path['slave_build']) 238 cwd=self.m.path['slave_build'])
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698