Source/bindings/tests/results/V8TestInterface.cpp - Issue 226073003: Fix StrictTypeChecking on interface type attributes

Unified Diff: Source/bindings/tests/results/V8TestInterface.cpp

Issue 226073003: Fix StrictTypeChecking on interface type attributes (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Adjust AudioBuffersourceNode.buffer. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/scripts/v8_attributes.py ('K') | « Source/bindings/tests/idls/TestObject.idl ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | Source/core/html/HTMLMediaElement.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterface.cpp

diff --git a/Source/bindings/tests/results/V8TestInterface.cpp b/Source/bindings/tests/results/V8TestInterface.cpp

index 6786f04c411eed064c14c4411c04002750249396..67cd448123710dad3b4d6af128bc5de57a956002 100644

--- a/Source/bindings/tests/results/V8TestInterface.cpp

+++ b/Source/bindings/tests/results/V8TestInterface.cpp

@@ -71,7 +71,7 @@ static void testInterfaceAttributeAttributeSetter(v8::Local<v8::Value> v8Value,

{

v8::Handle<v8::Object> holder = info.Holder();

ExceptionState exceptionState(ExceptionState::SetterContext, "testInterfaceAttribute", "TestInterface", holder, info.GetIsolate());

- if (!isUndefinedOrNull(v8Value) && !V8TestInterface::hasInstance(v8Value, info.GetIsolate())) {

+ if (!V8TestInterface::hasInstance(v8Value, info.GetIsolate())) {

exceptionState.throwTypeError("The provided value is not of type 'TestInterface'.");

exceptionState.throwIfNeeded();

return;

@@ -273,7 +273,7 @@ static void implementsNodeAttributeAttributeSetter(v8::Local<v8::Value> v8Value,

{

v8::Handle<v8::Object> holder = info.Holder();

ExceptionState exceptionState(ExceptionState::SetterContext, "implementsNodeAttribute", "TestInterface", holder, info.GetIsolate());

- if (!isUndefinedOrNull(v8Value) && !V8Node::hasInstance(v8Value, info.GetIsolate())) {

+ if (!V8Node::hasInstance(v8Value, info.GetIsolate())) {

exceptionState.throwTypeError("The provided value is not of type 'Node'.");

exceptionState.throwIfNeeded();

return;

@@ -342,7 +342,7 @@ static void implementsRuntimeEnabledNodeAttributeAttributeSetter(v8::Local<v8::V

{

v8::Handle<v8::Object> holder = info.Holder();

ExceptionState exceptionState(ExceptionState::SetterContext, "implementsRuntimeEnabledNodeAttribute", "TestInterface", holder, info.GetIsolate());

- if (!isUndefinedOrNull(v8Value) && !V8Node::hasInstance(v8Value, info.GetIsolate())) {

+ if (!V8Node::hasInstance(v8Value, info.GetIsolate())) {

exceptionState.throwTypeError("The provided value is not of type 'Node'.");

exceptionState.throwIfNeeded();

return;

@@ -379,7 +379,7 @@ static void implementsPerContextEnabledNodeAttributeAttributeSetter(v8::Local<v8

{

v8::Handle<v8::Object> holder = info.Holder();

ExceptionState exceptionState(ExceptionState::SetterContext, "implementsPerContextEnabledNodeAttribute", "TestInterface", holder, info.GetIsolate());

- if (!isUndefinedOrNull(v8Value) && !V8Node::hasInstance(v8Value, info.GetIsolate())) {

+ if (!V8Node::hasInstance(v8Value, info.GetIsolate())) {

exceptionState.throwTypeError("The provided value is not of type 'Node'.");

exceptionState.throwIfNeeded();

return;