Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

Issue 2260703004: Remove ContentSuggestionsProvider::GetProvidedCategories(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Philipp's comments and rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
index 978deb7c5431ba1b2d20c6e0e9cbd237d67abfef..9afd1fb244848c16fb0a14e62f07d9408b5887bd 100644
--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
@@ -28,7 +28,9 @@ PhysicalWebPageSuggestionsProvider::PhysicalWebPageSuggestionsProvider(
: ContentSuggestionsProvider(observer, category_factory),
category_status_(CategoryStatus::AVAILABLE_LOADING),
provided_category_(category_factory->FromKnownCategory(
- KnownCategories::PHYSICAL_WEB_PAGES)) {}
+ KnownCategories::PHYSICAL_WEB_PAGES)) {
+ observer->OnCategoryStatusChanged(this, provided_category_, category_status_);
+}
PhysicalWebPageSuggestionsProvider::~PhysicalWebPageSuggestionsProvider() {}
@@ -55,11 +57,6 @@ void PhysicalWebPageSuggestionsProvider::OnDisplayableUrlsChanged(
std::move(suggestions));
}
-std::vector<Category>
-PhysicalWebPageSuggestionsProvider::GetProvidedCategories() {
- return std::vector<Category>({provided_category_});
-}
-
CategoryStatus PhysicalWebPageSuggestionsProvider::GetCategoryStatus(
Category category) {
return category_status_;
« no previous file with comments | « components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698