Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: components/ntp_snippets/content_suggestions_provider.h

Issue 2260703004: Remove ContentSuggestionsProvider::GetProvidedCategories(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Philipp's comments and rebase. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/content_suggestions_provider.h
diff --git a/components/ntp_snippets/content_suggestions_provider.h b/components/ntp_snippets/content_suggestions_provider.h
index 836fd41996ddd1d2589959e73426e70f72194709..8e8eeffc9914bfcae2f180bc9035c6e856314482 100644
--- a/components/ntp_snippets/content_suggestions_provider.h
+++ b/components/ntp_snippets/content_suggestions_provider.h
@@ -49,11 +49,10 @@ class ContentSuggestionsProvider {
Category category,
std::vector<ContentSuggestion> suggestions) = 0;
- // Called when the status of a category changed.
+ // Called when the status of a category changed, including when it is added.
// If |new_status| is NOT_PROVIDED, the calling provider must be the one
// that currently provides the |category|, and the category is unregistered
- // without clearing the UI. The |category| must also be removed from
- // |GetProvidedCategories()|.
+ // without clearing the UI.
// If |new_status| is any other value, it must match the value that is
// currently returned from the provider's |GetCategoryStatus(category)|. In
// case the given |category| is not known yet, the calling |provider| will
@@ -81,13 +80,6 @@ class ContentSuggestionsProvider {
virtual ~ContentSuggestionsProvider();
- // Returns the categories provided by this provider.
- // When the set of provided categories changes, the Observer is notified
- // through |OnNewSuggestions| or |OnCategoryStatusChanged| for added
- // categories, and through |OnCategoryStatusChanged| with parameter
- // NOT_PROVIDED for removed categories.
- virtual std::vector<Category> GetProvidedCategories() = 0;
-
// Determines the status of the given |category|, see CategoryStatus.
virtual CategoryStatus GetCategoryStatus(Category category) = 0;

Powered by Google App Engine
This is Rietveld 408576698