Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc

Issue 2260703004: Remove ContentSuggestionsProvider::GetProvidedCategories(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
diff --git a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
index b98f843a638f88474b95e029e04f79264ae31d25..37c000240e98693349ba80a648e730874340cafc 100644
--- a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
+++ b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc
@@ -62,6 +62,14 @@ OfflinePageSuggestionsProvider::OfflinePageSuggestionsProvider(
pref_service_(pref_service),
download_manager_ui_enabled_(download_manager_ui_enabled) {
DCHECK(recent_tabs_enabled || downloads_enabled);
+ if (recent_tabs_enabled) {
+ observer->OnCategoryStatusChanged(this, recent_tabs_category_,
+ recent_tabs_status_);
+ }
+ if (downloads_enabled) {
+ observer->OnCategoryStatusChanged(this, downloads_category_,
+ downloads_status_);
+ }
offline_page_model_->AddObserver(this);
FetchOfflinePages();
}
@@ -80,15 +88,6 @@ void OfflinePageSuggestionsProvider::RegisterProfilePrefs(
////////////////////////////////////////////////////////////////////////////////
// Private methods
-std::vector<Category> OfflinePageSuggestionsProvider::GetProvidedCategories() {
- std::vector<Category> provided_categories;
- if (recent_tabs_status_ != CategoryStatus::NOT_PROVIDED)
- provided_categories.push_back(recent_tabs_category_);
- if (downloads_status_ != CategoryStatus::NOT_PROVIDED)
- provided_categories.push_back(downloads_category_);
- return provided_categories;
-}
-
CategoryStatus OfflinePageSuggestionsProvider::GetCategoryStatus(
Category category) {
if (category == recent_tabs_category_)

Powered by Google App Engine
This is Rietveld 408576698