components/ntp_snippets/content_suggestions_service.cc - Issue 2260703004: Remove ContentSuggestionsProvider::GetProvidedCategories().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/content_suggestions_service.cc

Issue 2260703004: Remove ContentSuggestionsProvider::GetProvidedCategories(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/ntp_snippets/content_suggestions_provider.h ('K') | « components/ntp_snippets/content_suggestions_provider.h ('k') | components/ntp_snippets/content_suggestions_service_unittest.cc » ('j') | components/ntp_snippets/content_suggestions_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/content_suggestions_service.cc

diff --git a/components/ntp_snippets/content_suggestions_service.cc b/components/ntp_snippets/content_suggestions_service.cc

index f9631e3115176f6361e628bb40c364a1c6d28394..a6f716bdcaba2fead142570ee755232899b720f2 100644

--- a/components/ntp_snippets/content_suggestions_service.cc

+++ b/components/ntp_snippets/content_suggestions_service.cc

@@ -152,12 +152,6 @@ void ContentSuggestionsService::RemoveObserver(Observer* observer) {

void ContentSuggestionsService::RegisterProvider(

std::unique_ptr<ContentSuggestionsProvider> provider) {

DCHECK(state_ == State::ENABLED);

- for (Category category : provider->GetProvidedCategories()) {

- DCHECK_NE(CategoryStatus::NOT_PROVIDED,

- provider->GetCategoryStatus(category));

- RegisterCategoryIfRequired(provider.get(), category);

- NotifyCategoryStatusChanged(category);

- }

providers_.push_back(std::move(provider));

}