Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: tests/standalone/vmservice/multiple_isolate_list_script.dart

Issue 22607005: Remove race(s) in vmservice tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/vmservice/multiple_isolate_list_script.dart
diff --git a/tests/standalone/vmservice/multiple_isolate_list_script.dart b/tests/standalone/vmservice/multiple_isolate_list_script.dart
index 21e6a0a0b72e7d25160df362bd6e879b77067b5e..128f61a0cc73e237dc3ab62f62222bd9db973026 100644
--- a/tests/standalone/vmservice/multiple_isolate_list_script.dart
+++ b/tests/standalone/vmservice/multiple_isolate_list_script.dart
@@ -8,7 +8,9 @@ import 'dart:io';
import 'dart:isolate';
void isolateMain1() {
- // Die immediately.
+ // Spawn another isolate.
+ spawnFunction(myIsolateName);
+ // Kill this isolate.
port.close();
}
@@ -17,12 +19,11 @@ void myIsolateName() {
port.receive((a, b) {
port.close();
});
+ print(''); // Print blank line to signal that we are ready.
}
main() {
spawnFunction(isolateMain1);
- spawnFunction(myIsolateName);
- print(''); // Print blank line to signal that we are ready.
// Wait until signaled from spawning test.
stdin.first.then((_) => exit(0));
}

Powered by Google App Engine
This is Rietveld 408576698