Fix an embedder test with leaked page object

fpdfsdk/fpdfedit_embeddertest.cpp

Index: fpdfsdk/fpdfedit_embeddertest.cpp
diff --git a/fpdfsdk/fpdfedit_embeddertest.cpp b/fpdfsdk/fpdfedit_embeddertest.cpp
index 720dcdec019109457151e47fde672c8add8e592b..6edd0de868a2e325eefc0acab39bff7a2dd7476d 100644
--- a/fpdfsdk/fpdfedit_embeddertest.cpp
+++ b/fpdfsdk/fpdfedit_embeddertest.cpp
@@ -55,7 +55,7 @@ const char kExpectedPDF[] =
 
 TEST_F(FPDFEditEmbeddertest, EmptyCreation) {
   EXPECT_TRUE(CreateEmptyDocument());
-  FPDF_PAGE page = FPDFPage_New(document(), 1, 640.0, 480.0);
+  FPDF_PAGE page = FPDFPage_New(document(), 0, 640.0, 480.0);
   EXPECT_NE(nullptr, page);
   EXPECT_TRUE(FPDFPage_GenerateContent(page));
   EXPECT_TRUE(FPDF_SaveAsCopy(document(), this, 0));
@@ -66,5 +66,8 @@ TEST_F(FPDFEditEmbeddertest, EmptyCreation) {
   std::replace(result.begin(), result.end(), '\0', '_');
   EXPECT_THAT(result, testing::MatchesRegex(
                           std::string(kExpectedPDF, sizeof(kExpectedPDF))));
-  FPDFPage_Delete(document(), 1);
+  // FPDFPage_New() doesn't add any new page into document if the page index is

[Tom Sepez, 2016/08/19 20:24:48]

This comment should be in a public/ header file.  How does an embedder know if
the page was in range and hence which function to use?  Sounds like Delete()
should be smarter and just handle all cases.

[Wei Li, 2016/08/19 22:25:27]

Done.

+  // not within document's existing page range. Use FPDF_ClosePage() instead of
+  // FPDFPage_Delete() to free the page.
+  FPDF_ClosePage(page);
 }