Fix an embedder test with leaked page object

fpdfsdk/fpdfedit_embeddertest.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "public/fpdf_edit.h"
 #include "public/fpdfview.h"
 #include "testing/embedder_test.h"
 #include "testing/gmock/include/gmock/gmock-matchers.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/test_support.h"
@@ skipping 37 matching lines @@
     "/Root 1 0 R\r\n"
     "/Info 3 0 R\r\n"
     "/Size 6/ID\\[<.*><.*>\\]>>\r\n"
     "startxref\r\n"
     "379\r\n"
     "%%EOF\r\n";
 }  // namespace
 
 TEST_F(FPDFEditEmbeddertest, EmptyCreation) {
   EXPECT_TRUE(CreateEmptyDocument());
-  FPDF_PAGE page = FPDFPage_New(document(), 1, 640.0, 480.0);
+  FPDF_PAGE page = FPDFPage_New(document(), 0, 640.0, 480.0);
   EXPECT_NE(nullptr, page);
   EXPECT_TRUE(FPDFPage_GenerateContent(page));
   EXPECT_TRUE(FPDF_SaveAsCopy(document(), this, 0));
 
   // The MatchesRegexp doesn't support embedded NUL ('\0') characters. They are
   // replaced by '_' for the purpose of the test.
   std::string result = GetString();
   std::replace(result.begin(), result.end(), '\0', '_');
   EXPECT_THAT(result, testing::MatchesRegex(
                           std::string(kExpectedPDF, sizeof(kExpectedPDF))));
-  FPDFPage_Delete(document(), 1);
+  // FPDFPage_New() doesn't add any new page into document if the page index is

[Tom Sepez, 2016/08/19 20:24:48]

This comment should be in a public/ header file.  How does an embedder know if
the page was in range and hence which function to use?  Sounds like Delete()
should be smarter and just handle all cases.

[Wei Li, 2016/08/19 22:25:27]

Done.

+  // not within document's existing page range. Use FPDF_ClosePage() instead of
+  // FPDFPage_Delete() to free the page.
+  FPDF_ClosePage(page);
 }