chrome/browser/resources/settings/people_page/setup_pin_dialog.html - Issue 2260653002: Pin keyboard works with virtual keyboard.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/setup_pin_dialog.html

Issue 2260653002: Pin keyboard works with virtual keyboard. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Fixed patch set 1 errors. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js ('K') | « chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js ('k') | chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h » ('j') | ui/login/account_picker/screen_account_picker.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/people_page/setup_pin_dialog.html

diff --git a/chrome/browser/resources/settings/people_page/setup_pin_dialog.html b/chrome/browser/resources/settings/people_page/setup_pin_dialog.html

index 0c6ab823ea8bef1e021d573be1cb65a92573850b..163eb9712be6b39c76fdfc6ee990d6419f204206 100644

--- a/chrome/browser/resources/settings/people_page/setup_pin_dialog.html

+++ b/chrome/browser/resources/settings/people_page/setup_pin_dialog.html

@@ -46,7 +46,8 @@

<pin-keyboard id="pinKeyboard" on-pin-change="onPinChange_"

- on-submit="onPinSubmit_" value="{{pinKeyboardValue_}}">

+ on-submit="onPinSubmit_" value="{{pinKeyboardValue_}}"

+ enable-input-shown>

jdufault 2016/08/24 01:35:10 rename to show-input?

sammiequon 2016/08/25 18:12:33 Done.

</pin-keyboard>

</div>