Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5032)

Unified Diff: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html

Issue 2260653002: Pin keyboard works with virtual keyboard. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Fixed patch set 1 errors. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
diff --git a/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html b/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
index ffc5a62da781827ea2dc7207763f2cda46755d4c..868ea5799dff73466b2d0718953d37b83eb147a6 100644
--- a/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
+++ b/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
@@ -38,6 +38,10 @@
display: flex;
}
+ .row.first-row {
+ height: 64px;
+ }
+
.digit-button {
align-items: center;
background: none;
@@ -112,12 +116,6 @@
height: 52px;
}
- .first-row {
- height: 64px;
- min-height: 64px;
- padding: 28px 15px 12px 15px;
- }
-
#pin-input {
-webkit-text-security: disc;
background-color: white;
@@ -152,22 +150,16 @@
}
</style>
- <div id="root">
+ <div id="root" on-keypress="onKeyPress_" on-keydown="onKeyDown_">
<div id="container-constrained-width">
- <div class="row">
+ <div class="row first-row">
<input id="pin-input" type="[[getInputType_(enablePassword)]]"
class$="[[getInputClass_(value)]]
[[getSubmitHiddenClass_(enableSubmitButton)]]"
placeholder="[[getInputPlaceholder_(enablePassword)]]"
value="{{value::input}}"
- on-keydown="onInputKeyDown_"></input>
- <paper-button class$="digit-button first-row submit-button
- [[getSubmitHiddenClass_(enableSubmitButton)]]"
- on-tap="firePinSubmitEvent_">
- <div class$="icon-container [[getSubmitClass_(value)]]">
- <iron-icon class="icon" icon="pin-keyboard:forward"><iron-icon>
- </div>
- </paper-button>
+ on-keydown="onInputKeyDown_">
+ </input>
</div>
<div class="row keyboard">

Powered by Google App Engine
This is Rietveld 408576698