Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3758)

Unified Diff: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html

Issue 2260653002: Pin keyboard works with virtual keyboard. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
diff --git a/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html b/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
index ffc5a62da781827ea2dc7207763f2cda46755d4c..6bb1f815c85f5fc00fca417dde1081997f1af216 100644
--- a/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
+++ b/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html
@@ -38,6 +38,10 @@
display: flex;
}
+ .row.first-row {
+ height: 64px;
+ }
+
.digit-button {
align-items: center;
background: none;
@@ -112,12 +116,6 @@
height: 52px;
}
- .first-row {
- height: 64px;
- min-height: 64px;
- padding: 28px 15px 12px 15px;
- }
-
#pin-input {
-webkit-text-security: disc;
background-color: white;
@@ -154,65 +152,72 @@
<div id="root">
<div id="container-constrained-width">
- <div class="row">
+ <div class="row first-row">
<input id="pin-input" type="[[getInputType_(enablePassword)]]"
class$="[[getInputClass_(value)]]
[[getSubmitHiddenClass_(enableSubmitButton)]]"
placeholder="[[getInputPlaceholder_(enablePassword)]]"
value="{{value::input}}"
- on-keydown="onInputKeyDown_"></input>
- <paper-button class$="digit-button first-row submit-button
- [[getSubmitHiddenClass_(enableSubmitButton)]]"
- on-tap="firePinSubmitEvent_">
- <div class$="icon-container [[getSubmitClass_(value)]]">
- <iron-icon class="icon" icon="pin-keyboard:forward"><iron-icon>
- </div>
- </paper-button>
+ on-keydown="onInputKeyDown_"
+ hidden>
+ </input>
</div>
<div class="row keyboard">
jdufault 2016/08/19 17:28:18 Can the on-keypress and on-keydown events be captu
sammiequon 2016/08/23 17:28:11 Done.
- <paper-button class="digit-button" on-tap="onNumberTap_" value="1">
+ <paper-button class="digit-button" on-keypress="onKeyPress_"
+ on-keydown="onKeyDown_" on-tap="onNumberTap_" value="1">
<inner-text>$i18n{pinKeyboard1}</inner-text>
</paper-button>
- <paper-button class="digit-button center-button" on-tap="onNumberTap_"
- value="2">
+ <paper-button class="digit-button center-button"
+ on-keypress="onKeyPress_" on-keydown="onKeyDown_"
+ on-tap="onNumberTap_" value="2">
<inner-text>$i18n{pinKeyboard2}</inner-text>
</paper-button>
- <paper-button class="digit-button" on-tap="onNumberTap_" value="3">
+ <paper-button class="digit-button" on-keypress="onKeyPress_"
+ on-keydown="onKeyDown_" on-tap="onNumberTap_" value="3">
<inner-text>$i18n{pinKeyboard3}</inner-text>
</paper-button>
</div>
<div class="row keyboard">
- <paper-button class="digit-button" on-tap="onNumberTap_" value="4">
+ <paper-button class="digit-button" on-keypress="onKeyPress_"
+ on-keydown="onKeyDown_" on-tap="onNumberTap_" value="4">
<inner-text>$i18n{pinKeyboard4}</inner-text>
</paper-button>
- <paper-button class="digit-button center-button" on-tap="onNumberTap_"
- value="5">
+ <paper-button class="digit-button center-button"
+ on-keypress="onKeyPress_" on-keydown="onKeyDown_"
+ on-tap="onNumberTap_" value="5">
<inner-text>$i18n{pinKeyboard5}</inner-text>
</paper-button>
- <paper-button class="digit-button" on-tap="onNumberTap_" value="6">
+ <paper-button class="digit-button" on-keypress="onKeyPress_"
+ on-keydown="onKeyDown_" on-tap="onNumberTap_" value="6">
<inner-text>$i18n{pinKeyboard6}</inner-text>
</paper-button>
</div>
<div class="row keyboard">
- <paper-button class="digit-button" on-tap="onNumberTap_" value="7">
+ <paper-button class="digit-button" on-keypress="onKeyPress_"
+ on-keydown="onKeyDown_" on-tap="onNumberTap_" value="7">
<inner-text>$i18n{pinKeyboard7}</inner-text>
</paper-button>
- <paper-button class="digit-button center-button" on-tap="onNumberTap_"
- value="8">
+ <paper-button class="digit-button center-button"
+ on-keypress="onKeyPress_" on-keydown="onKeyDown_"
+ on-tap="onNumberTap_" value="8">
<inner-text>$i18n{pinKeyboard8}</inner-text>
</paper-button>
- <paper-button class="digit-button" on-tap="onNumberTap_" value="9">
+ <paper-button class="digit-button" on-keypress="onKeyPress_"
+ on-keydown="onKeyDown_" on-tap="onNumberTap_" value="9">
<inner-text>$i18n{pinKeyboard9}</inner-text>
</paper-button>
</div>
<div class="row keyboard">
<div class="digit-button"></div>
- <paper-button class="digit-button center-button" on-tap="onNumberTap_"
- value="0">
+ <paper-button class="digit-button center-button"
+ on-keypress="onKeyPress_" on-keydown="onKeyDown_"
+ on-tap="onNumberTap_" value="0">
<inner-text>$i18n{pinKeyboard0}</inner-text>
</paper-button>
- <paper-button class="digit-button clear-button" on-tap="onPinClear_">
+ <paper-button class="digit-button clear-button"
+ on-keypress="onKeyPress_" on-keydown="onKeyDown_"
+ on-tap="onPinClear_">
<div class="icon-container">
<iron-icon class="icon" icon="cr:clear"><iron-icon>
</div>

Powered by Google App Engine
This is Rietveld 408576698