Pin keyboard works with virtual keyboard.

Pin keyboard works with virtual keyboard.

The pin keyboard now hides its input element and passes its data to the user pod password element.

BUG=632383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d1ed179e46f28f6681d91a12635419aa4a9feed3
Cr-Commit-Position: refs/heads/master@{#415155}

[sammiequon, 2016-08-18 20:55:11]

Description was changed from

==========
Pin keyboard works with virtual keyboard.

BUG=632383
==========

to

==========
Pin keyboard works with virtual keyboard.

BUG=632383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2016-08-18 21:10:06]

Patchset #1 (id:1) has been deleted

[sammiequon, 2016-08-18 21:15:20]

Description was changed from

==========
Pin keyboard works with virtual keyboard.

BUG=632383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Pin keyboard works with virtual keyboard.

The pin keyboard now hides its input element and passes its data to the user pod
password element.

BUG=632383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2016-08-18 22:27:18]

sammiequon@chromium.org changed reviewers:
+ jdufault@chromium.org

[sammiequon, 2016-08-18 22:27:34]

On 2016/08/18 22:27:18, sammiequon wrote:
> mailto:sammiequon@chromium.org changed reviewers:
> + mailto:jdufault@chromium.org

jdufault@ - Please take a look. Thanks!

[jdufault, 2016-08-19 01:06:47]

I'll take a closer look later.

https://codereview.chromium.org/2260653002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js (right):

https://codereview.chromium.org/2260653002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:78: this.value =
newValue;
We should be able to assign to value directly which means this function
shouldn't be needed.

https://codereview.chromium.org/2260653002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:164: this.value
+= stringValue;
eliminate stringValue temp

https://codereview.chromium.org/2260653002/diff/20001/ui/login/account_picker...
File ui/login/account_picker/user_pod_row.js (right):

https://codereview.chromium.org/2260653002/diff/20001/ui/login/account_picker...
ui/login/account_picker/user_pod_row.js:2413: dontShowPinOverride_: false,
forceHidePin?

[jdufault, 2016-08-19 17:28:18]

https://codereview.chromium.org/2260653002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html (right):

https://codereview.chromium.org/2260653002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html:166: <div
class="row keyboard">
Can the on-keypress and on-keydown events be captured by the "root" div or this
div?

https://codereview.chromium.org/2260653002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js (right):

https://codereview.chromium.org/2260653002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:107: /** Called
when the user wants to erase the last character of the entered
Please fix this comment's formatting, ie,

/**
 * Called when ...
 */

https://codereview.chromium.org/2260653002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc (right):

https://codereview.chromium.org/2260653002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc:279:
CallJSOrDefer("showPinKeyboard", show);
Will this cause the PIN keyboard to show up when it should not? For example, I
timeout PIN from too many attempts, and then show/hide the virtual keyboard.

https://codereview.chromium.org/2260653002/diff/20001/ui/login/account_picker...
File ui/login/account_picker/user_pod_row.js (right):

https://codereview.chromium.org/2260653002/diff/20001/ui/login/account_picker...
ui/login/account_picker/user_pod_row.js:2606: this.dontShowPinOverride_ = true;
We have code that fires when the PIN keyboard is finished loading. Can that code
check Oobe.getInstance().hidePin instead of introducing dontShowPinOverride_?

https://codereview.chromium.org/2260653002/diff/20001/ui/login/account_picker...
ui/login/account_picker/user_pod_row.js:2610:
this.setFocusedPodPinVisibility(true);
need {}

https://codereview.chromium.org/2260653002/diff/20001/ui/login/account_picker...
ui/login/account_picker/user_pod_row.js:3169: if (!this.dontShowPinOverride_)
combine if statements

[sammiequon, 2016-08-23 17:28:12]

https://codereview.chromium.org/2260653002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html (right):

https://codereview.chromium.org/2260653002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html:166: <div
class="row keyboard">
On 2016/08/19 17:28:18, jdufault wrote:
> Can the on-keypress and on-keydown events be captured by the "root" div or
this
> div?

Done.

https://codereview.chromium.org/2260653002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js (right):

https://codereview.chromium.org/2260653002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:78: this.value =
newValue;
On 2016/08/19 01:06:47, jdufault wrote:
> We should be able to assign to value directly which means this function
> shouldn't be needed.

Done.

https://codereview.chromium.org/2260653002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:107: /** Called
when the user wants to erase the last character of the entered
On 2016/08/19 17:28:18, jdufault wrote:
> Please fix this comment's formatting, ie,
> 
> /**
>  * Called when ...
>  */

Done.

https://codereview.chromium.org/2260653002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:164: this.value
+= stringValue;
On 2016/08/19 01:06:47, jdufault wrote:
> eliminate stringValue temp

Done.

https://codereview.chromium.org/2260653002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc (right):

https://codereview.chromium.org/2260653002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc:279:
CallJSOrDefer("showPinKeyboard", show);
On 2016/08/19 17:28:18, jdufault wrote:
> Will this cause the PIN keyboard to show up when it should not? For example, I
> timeout PIN from too many attempts, and then show/hide the virtual keyboard.

Yes, as mentioned we will delete the pin keyboard after too many bad attempts,
so nothing can show it until locked again.

https://codereview.chromium.org/2260653002/diff/20001/ui/login/account_picker...
File ui/login/account_picker/user_pod_row.js (right):

https://codereview.chromium.org/2260653002/diff/20001/ui/login/account_picker...
ui/login/account_picker/user_pod_row.js:2413: dontShowPinOverride_: false,
On 2016/08/19 01:06:47, jdufault wrote:
> forceHidePin?

Removed.

https://codereview.chromium.org/2260653002/diff/20001/ui/login/account_picker...
ui/login/account_picker/user_pod_row.js:2606: this.dontShowPinOverride_ = true;
On 2016/08/19 17:28:18, jdufault wrote:
> We have code that fires when the PIN keyboard is finished loading. Can that
code
> check Oobe.getInstance().hidePin instead of introducing dontShowPinOverride_?

Done.

https://codereview.chromium.org/2260653002/diff/20001/ui/login/account_picker...
ui/login/account_picker/user_pod_row.js:2610:
this.setFocusedPodPinVisibility(true);
On 2016/08/19 17:28:18, jdufault wrote:
> need {}

Removed.

https://codereview.chromium.org/2260653002/diff/20001/ui/login/account_picker...
ui/login/account_picker/user_pod_row.js:3169: if (!this.dontShowPinOverride_)
On 2016/08/19 17:28:18, jdufault wrote:
> combine if statements

Removed.

[jdufault, 2016-08-24 01:35:11]

https://codereview.chromium.org/2260653002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js (right):

https://codereview.chromium.org/2260653002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:74: showInput_:
function(show) {
Use a property binding

https://codereview.chromium.org/2260653002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/setup_pin_dialog.html
(right):

https://codereview.chromium.org/2260653002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/setup_pin_dialog.html:50:
enable-input-shown>
rename to show-input?

https://codereview.chromium.org/2260653002/diff/40001/ui/login/account_picker...
File ui/login/account_picker/screen_account_picker.js (right):

https://codereview.chromium.org/2260653002/diff/40001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.js:186: var showBottomCallback =
function() {
Does this work if we are not showing the PIN keyboard by default? Where does the
transitionend event come from?

https://codereview.chromium.org/2260653002/diff/40001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.js:193:
activatedPod.addEventListener("transitionend",showBottomCallback,
Add ensureTransitionEndEvent guards

https://codereview.chromium.org/2260653002/diff/40001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.js:193:
activatedPod.addEventListener("transitionend",showBottomCallback,
Add space after comma

https://codereview.chromium.org/2260653002/diff/40001/ui/login/account_picker...
File ui/login/account_picker/user_pod_row.js (right):

https://codereview.chromium.org/2260653002/diff/40001/ui/login/account_picker...
ui/login/account_picker/user_pod_row.js:1118: if (visible &&
Oobe.getInstance().headerHidden)
Add a helper method hasVirtualKeyboard on the Oobe instance so that we are not
relying less on incidental behavior that may change in the future.

https://codereview.chromium.org/2260653002/diff/40001/ui/login/account_picker...
ui/login/account_picker/user_pod_row.js:2634: // again after three tries.
setPinVisiblity is named and read such that the PIN keyboard can be
enabled/disabled at will, even it is has already been enabled.

Removing the DOM should be done inside of disablePinKeyboardForUser or in a
method where it is clear the PIN keyboard is erased and cannot be shown anymore.

https://codereview.chromium.org/2260653002/diff/40001/ui/login/account_picker...
ui/login/account_picker/user_pod_row.js:2637: pod.setPinVisibility(false);
What if |visible| is true?

If this function is only used for destroying the PIN keyboard, it should be
called removePinKeyboard or similar and the |visible| param should be removed.

[sammiequon, 2016-08-25 18:12:34]

https://codereview.chromium.org/2260653002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js (right):

https://codereview.chromium.org/2260653002/diff/40001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:74: showInput_:
function(show) {
On 2016/08/24 01:35:10, jdufault wrote:
> Use a property binding

Done.

https://codereview.chromium.org/2260653002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/people_page/setup_pin_dialog.html
(right):

https://codereview.chromium.org/2260653002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/people_page/setup_pin_dialog.html:50:
enable-input-shown>
On 2016/08/24 01:35:10, jdufault wrote:
> rename to show-input?

Done.

https://codereview.chromium.org/2260653002/diff/40001/ui/login/account_picker...
File ui/login/account_picker/screen_account_picker.js (right):

https://codereview.chromium.org/2260653002/diff/40001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.js:186: var showBottomCallback =
function() {
On 2016/08/24 01:35:11, jdufault wrote:
> Does this work if we are not showing the PIN keyboard by default? Where does
the
> transitionend event come from?

Yes. The transition end event comes from the pod.

https://codereview.chromium.org/2260653002/diff/40001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.js:193:
activatedPod.addEventListener("transitionend",showBottomCallback,
On 2016/08/24 01:35:11, jdufault wrote:
> Add space after comma

Done.

https://codereview.chromium.org/2260653002/diff/40001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.js:193:
activatedPod.addEventListener("transitionend",showBottomCallback,
On 2016/08/24 01:35:10, jdufault wrote:
> Add ensureTransitionEndEvent guards

Done.

https://codereview.chromium.org/2260653002/diff/40001/ui/login/account_picker...
File ui/login/account_picker/user_pod_row.js (right):

https://codereview.chromium.org/2260653002/diff/40001/ui/login/account_picker...
ui/login/account_picker/user_pod_row.js:1118: if (visible &&
Oobe.getInstance().headerHidden)
On 2016/08/24 01:35:11, jdufault wrote:
> Add a helper method hasVirtualKeyboard on the Oobe instance so that we are not
> relying less on incidental behavior that may change in the future.

Done.

https://codereview.chromium.org/2260653002/diff/40001/ui/login/account_picker...
ui/login/account_picker/user_pod_row.js:2634: // again after three tries.
On 2016/08/24 01:35:11, jdufault wrote:
> setPinVisiblity is named and read such that the PIN keyboard can be
> enabled/disabled at will, even it is has already been enabled.
> 
> Removing the DOM should be done inside of disablePinKeyboardForUser or in a
> method where it is clear the PIN keyboard is erased and cannot be shown
anymore.

Done.

https://codereview.chromium.org/2260653002/diff/40001/ui/login/account_picker...
ui/login/account_picker/user_pod_row.js:2637: pod.setPinVisibility(false);
On 2016/08/24 01:35:11, jdufault wrote:
> What if |visible| is true?
> 
> If this function is only used for destroying the PIN keyboard, it should be
> called removePinKeyboard or similar and the |visible| param should be removed.

Done.

[jdufault, 2016-08-25 18:35:09]

https://codereview.chromium.org/2260653002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js (right):

https://codereview.chromium.org/2260653002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:45: showInput: {
I think the default should be showing an input element (so rename this to
hideInput = false by default)

https://codereview.chromium.org/2260653002/diff/60001/ui/login/account_picker...
File ui/login/account_picker/screen_account_picker.js (right):

https://codereview.chromium.org/2260653002/diff/60001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.js:197:
ensureTransitionEndEvent(activatedPod, 200);
Remove 200, ensureTransitionEndEvent(activatedPod) will lookup the transition by
with +50ms padding by default.

https://codereview.chromium.org/2260653002/diff/60001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.js:212: false);
Do you need the false parameter?

https://codereview.chromium.org/2260653002/diff/60001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.js:214:
ensureTransitionEndEvent(activatedPod, 200);
Ditto

https://codereview.chromium.org/2260653002/diff/60001/ui/login/account_picker...
File ui/login/account_picker/user_pod_row.js (right):

https://codereview.chromium.org/2260653002/diff/60001/ui/login/account_picker...
ui/login/account_picker/user_pod_row.js:1123: this.updatePinClass_(elements[i],
this.pinKeyboard? visible : false);
Should this function even be getting called when there is no pinKeyboard?

Also, space before ?

[sammiequon, 2016-08-25 23:29:40]

https://codereview.chromium.org/2260653002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js (right):

https://codereview.chromium.org/2260653002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:45: showInput: {
On 2016/08/25 18:35:08, jdufault wrote:
> I think the default should be showing an input element (so rename this to
> hideInput = false by default)

Done.

https://codereview.chromium.org/2260653002/diff/60001/ui/login/account_picker...
File ui/login/account_picker/screen_account_picker.js (right):

https://codereview.chromium.org/2260653002/diff/60001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.js:197:
ensureTransitionEndEvent(activatedPod, 200);
On 2016/08/25 18:35:09, jdufault wrote:
> Remove 200, ensureTransitionEndEvent(activatedPod) will lookup the transition
by
> with +50ms padding by default.

Done.

https://codereview.chromium.org/2260653002/diff/60001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.js:212: false);
On 2016/08/25 18:35:09, jdufault wrote:
> Do you need the false parameter?

According to the web, some old browsers still need this useCapture to be set
explicitly.

https://codereview.chromium.org/2260653002/diff/60001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.js:214:
ensureTransitionEndEvent(activatedPod, 200);
On 2016/08/25 18:35:08, jdufault wrote:
> Ditto

Done.

https://codereview.chromium.org/2260653002/diff/60001/ui/login/account_picker...
File ui/login/account_picker/user_pod_row.js (right):

https://codereview.chromium.org/2260653002/diff/60001/ui/login/account_picker...
ui/login/account_picker/user_pod_row.js:1123: this.updatePinClass_(elements[i],
this.pinKeyboard? visible : false);
On 2016/08/25 18:35:09, jdufault wrote:
> Should this function even be getting called when there is no pinKeyboard?
> 
> Also, space before ?

Done.

[jdufault, 2016-08-26 01:12:31]

lgtm

https://codereview.chromium.org/2260653002/diff/60001/ui/login/account_picker...
File ui/login/account_picker/screen_account_picker.js (right):

https://codereview.chromium.org/2260653002/diff/60001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.js:212: false);
On 2016/08/25 23:29:40, sammiequon wrote:
> On 2016/08/25 18:35:09, jdufault wrote:
> > Do you need the false parameter?
> 
> According to the web, some old browsers still need this useCapture to be set
> explicitly.

This code will only ever run on Chrome (and possibly also Chrome iOS).

https://codereview.chromium.org/2260653002/diff/80001/ui/login/account_picker...
File ui/login/account_picker/screen_account_picker.js (right):

https://codereview.chromium.org/2260653002/diff/80001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.js:196: // Guard timer set to
animation duration + 50ms.
Remove comment

[sammiequon, 2016-08-29 18:16:03]

Patchset #5 (id:100001) has been deleted

[sammiequon, 2016-08-29 21:57:01]

sammiequon@chromium.org changed reviewers:
+ achuith@chromium.org

[sammiequon, 2016-08-29 21:57:36]

Patchset #6 (id:140001) has been deleted

[sammiequon, 2016-08-29 22:00:21]

achuithb@ - Please take a look. Thanks!

https://codereview.chromium.org/2260653002/diff/60001/ui/login/account_picker...
File ui/login/account_picker/screen_account_picker.js (right):

https://codereview.chromium.org/2260653002/diff/60001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.js:212: false);
On 2016/08/26 01:12:30, jdufault wrote:
> On 2016/08/25 23:29:40, sammiequon wrote:
> > On 2016/08/25 18:35:09, jdufault wrote:
> > > Do you need the false parameter?
> > 
> > According to the web, some old browsers still need this useCapture to be set
> > explicitly.
> 
> This code will only ever run on Chrome (and possibly also Chrome iOS).

Done.

https://codereview.chromium.org/2260653002/diff/80001/ui/login/account_picker...
File ui/login/account_picker/screen_account_picker.js (right):

https://codereview.chromium.org/2260653002/diff/80001/ui/login/account_picker...
ui/login/account_picker/screen_account_picker.js:196: // Guard timer set to
animation duration + 50ms.
On 2016/08/26 01:12:31, jdufault wrote:
> Remove comment

Done.

[achuithb, 2016-08-29 22:09:32]

rubberstamp lgtm

[sammiequon, 2016-08-29 22:16:09]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[sammiequon, 2016-08-29 22:16:16]

The CQ bit was unchecked by sammiequon@chromium.org

[sammiequon, 2016-08-29 22:16:21]

The CQ bit was checked by sammiequon@chromium.org

[sammiequon, 2016-08-29 22:16:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdufault@chromium.org
Link to the patchset: https://codereview.chromium.org/2260653002/#ps160001
(title: "Fixed positioning of pod after tranisitions.")

[commit-bot: I haz the power, 2016-08-29 22:47:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sammiequon, 2016-08-29 23:35:30]

The CQ bit was unchecked by sammiequon@chromium.org

[sammiequon, 2016-08-29 23:40:06]

The CQ bit was checked by sammiequon@chromium.org

[sammiequon, 2016-08-29 23:40:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdufault@chromium.org, achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2260653002/#ps180001
(title: "Fixed closure compilation.")

[jdufault, 2016-08-29 23:58:38]

https://codereview.chromium.org/2260653002/diff/180001/chrome/browser/resourc...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html (right):

https://codereview.chromium.org/2260653002/diff/180001/chrome/browser/resourc...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html:184:
<paper-button class="digit-button center-button" on-tap="onNumberTap_"
Are these accidental rebase changes?

https://codereview.chromium.org/2260653002/diff/180001/ui/login/account_picke...
File ui/login/account_picker/user_pod_row.js (right):

https://codereview.chromium.org/2260653002/diff/180001/ui/login/account_picke...
ui/login/account_picker/user_pod_row.js:2978: setTimeout(function(param1) {
Please rename parameter

[sammiequon, 2016-08-29 23:59:25]

The CQ bit was unchecked by sammiequon@chromium.org

[sammiequon, 2016-08-30 01:24:56]

https://codereview.chromium.org/2260653002/diff/180001/chrome/browser/resourc...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html (right):

https://codereview.chromium.org/2260653002/diff/180001/chrome/browser/resourc...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html:184:
<paper-button class="digit-button center-button" on-tap="onNumberTap_"
On 2016/08/29 23:58:38, jdufault wrote:
> Are these accidental rebase changes?

Yes rebased from last weeks cl.

https://codereview.chromium.org/2260653002/diff/180001/ui/login/account_picke...
File ui/login/account_picker/user_pod_row.js (right):

https://codereview.chromium.org/2260653002/diff/180001/ui/login/account_picke...
ui/login/account_picker/user_pod_row.js:2978: setTimeout(function(param1) {
On 2016/08/29 23:58:38, jdufault wrote:
> Please rename parameter

Done.

[sammiequon, 2016-08-30 01:25:01]

The CQ bit was checked by sammiequon@chromium.org

[sammiequon, 2016-08-30 01:25:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdufault@chromium.org, achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2260653002/#ps200001
(title: "Nit.")

[commit-bot: I haz the power, 2016-08-30 01:51:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 05:27:45]

Description was changed from

==========
Pin keyboard works with virtual keyboard.

The pin keyboard now hides its input element and passes its data to the user pod
password element.

BUG=632383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Pin keyboard works with virtual keyboard.

The pin keyboard now hides its input element and passes its data to the user pod
password element.

BUG=632383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-30 05:27:46]

Committed patchset #8 (id:200001)

[commit-bot: I haz the power, 2016-08-30 05:31:20]

Description was changed from

==========
Pin keyboard works with virtual keyboard.

The pin keyboard now hides its input element and passes its data to the user pod
password element.

BUG=632383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Pin keyboard works with virtual keyboard.

The pin keyboard now hides its input element and passes its data to the user pod
password element.

BUG=632383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d1ed179e46f28f6681d91a12635419aa4a9feed3
Cr-Commit-Position: refs/heads/master@{#415155}
==========

[commit-bot: I haz the power, 2016-08-30 05:31:21]

Patchset 8 (id:??) landed as
https://crrev.com/d1ed179e46f28f6681d91a12635419aa4a9feed3
Cr-Commit-Position: refs/heads/master@{#415155}