mac: Update relauncher to not use deprecated APIs.

mac: Update relauncher to not use deprecated APIs.

FSRef has been deprecated since OS X 10.8. Switch the relauncher over to using
the more modern NSWorkspace API.

BUG=622481
Committed: https://crrev.com/bd7026fe500c0b56d60e06fdfda9f73bd0a2ce16
Cr-Commit-Position: refs/heads/master@{#413495}

[erikchen, 2016-08-18 21:47:56]

Description was changed from

==========
Update relauncher to not use deprecated APIs.

BUG=
==========

to

==========
mac: Update relauncher to not use deprecated APIs.

FSRef has been deprecated since OS X 10.8. Switch the relauncher over to using
the more modern NSWorkspace API.

BUG=622481
==========

[erikchen, 2016-08-18 21:48:04]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2016-08-18 21:48:37]

erikchen@chromium.org changed reviewers:
+ mark@chromium.org

[erikchen, 2016-08-18 21:48:38]

mark: Please review.

[commit-bot: I haz the power, 2016-08-18 21:48:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 22:33:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 22:33:30]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-08-22 17:36:07]

erikchen@chromium.org changed reviewers:
+ thakis@chromium.org

[erikchen, 2016-08-22 17:36:07]

thakis: Please review.

[Mark Mentovai, 2016-08-22 17:43:32]

LGTM otherwise

https://codereview.chromium.org/2260633004/diff/40001/chrome/browser/mac/rela...
File chrome/browser/mac/relauncher.mm (right):

https://codereview.chromium.org/2260633004/diff/40001/chrome/browser/mac/rela...
chrome/browser/mac/relauncher.mm:281: // The capacity for relaunch_args is 4
less than argc, because it
This comment has become pointless, uneless you switch to -initWithCapacity:.

https://codereview.chromium.org/2260633004/diff/40001/chrome/browser/mac/rela...
chrome/browser/mac/relauncher.mm:343:
initWithCString:relaunch_executable.c_str()
Wouldn’t we usually -initWithUTF8String?

Technically, -[NSFileManager stringWithFileSystemRepresentation:length:] is
probably most correct as the inverse of -[NSString fileSystemRepresentation],
but I think that we use -[NSString initWithUTF8String] (or SysUTF8ToNSString())
just about everywhere.

[erikchen, 2016-08-22 17:54:12]

https://codereview.chromium.org/2260633004/diff/40001/chrome/browser/mac/rela...
File chrome/browser/mac/relauncher.mm (right):

https://codereview.chromium.org/2260633004/diff/40001/chrome/browser/mac/rela...
chrome/browser/mac/relauncher.mm:281: // The capacity for relaunch_args is 4
less than argc, because it
On 2016/08/22 17:43:32, Mark Mentovai wrote:
> This comment has become pointless, uneless you switch to -initWithCapacity:.

Made the switch.

https://codereview.chromium.org/2260633004/diff/40001/chrome/browser/mac/rela...
chrome/browser/mac/relauncher.mm:343:
initWithCString:relaunch_executable.c_str()
On 2016/08/22 17:43:31, Mark Mentovai wrote:
> Wouldn’t we usually -initWithUTF8String?
> 
> Technically, -[NSFileManager stringWithFileSystemRepresentation:length:] is
> probably most correct as the inverse of -[NSString fileSystemRepresentation],
> but I think that we use -[NSString initWithUTF8String] (or
SysUTF8ToNSString())
> just about everywhere.

Switched to base::SysUTF8ToNSString

[erikchen, 2016-08-22 17:54:16]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-08-22 17:54:16]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/2260633004/#ps60001
(title: "Comments from mark.")

[commit-bot: I haz the power, 2016-08-22 17:54:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2016-08-22 17:56:47]

https://codereview.chromium.org/2260633004/diff/60001/chrome/browser/mac/rela...
File chrome/browser/mac/relauncher.mm (right):

https://codereview.chromium.org/2260633004/diff/60001/chrome/browser/mac/rela...
chrome/browser/mac/relauncher.mm:327: NSString* arg_string =
base::SysUTF8ToNSString(arg);
Are we sure we have an autorelease pool when this runs? We may not.

[erikchen, 2016-08-22 17:57:30]

The CQ bit was unchecked by erikchen@chromium.org

[erikchen, 2016-08-22 18:05:21]

https://codereview.chromium.org/2260633004/diff/60001/chrome/browser/mac/rela...
File chrome/browser/mac/relauncher.mm (right):

https://codereview.chromium.org/2260633004/diff/60001/chrome/browser/mac/rela...
chrome/browser/mac/relauncher.mm:327: NSString* arg_string =
base::SysUTF8ToNSString(arg);
On 2016/08/22 17:56:47, Mark Mentovai wrote:
> Are we sure we have an autorelease pool when this runs? We may not.
I don't believe so. Here's a stack trace:

"""
Stack trace:
0   Chromium Framework                  0x000000010dff5983
_ZN4base5debug10StackTraceC1Ev + 19
1   Chromium Framework                  0x000000010dbe6320
_ZN14mac_relauncher8internal14RelauncherMainERKN7content18MainFunctionParamsE +
2224
2   Chromium Framework                  0x000000010db500a8
_ZN7content21ContentMainRunnerImpl3RunEv + 552
3   Chromium Framework                  0x000000010db4f226
_ZN7content11ContentMainERKNS_17ContentMainParamsE + 54
4   Chromium Framework                  0x000000010c3fcbea ChromeMain + 58
5   Chromium Helper                     0x000000010c1c5d6a main + 522
6   Chromium Helper                     0x000000010c1c5b54 start + 52
7   ???                                 0x0000000000000006 0x0 + 6
"""

I added an autorelease pool, since AppKit methods generally assume that they are
called within an autoreleasepool context.

[erikchen, 2016-08-22 18:06:14]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-08-22 18:06:15]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/2260633004/#ps80001
(title: "Add autorelease pool.")

[commit-bot: I haz the power, 2016-08-22 18:06:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2016-08-22 18:07:27]

Exactly. LGTM with the autorelease pool.

[commit-bot: I haz the power, 2016-08-22 18:58:36]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-22 19:04:04]

Description was changed from

==========
mac: Update relauncher to not use deprecated APIs.

FSRef has been deprecated since OS X 10.8. Switch the relauncher over to using
the more modern NSWorkspace API.

BUG=622481
==========

to

==========
mac: Update relauncher to not use deprecated APIs.

FSRef has been deprecated since OS X 10.8. Switch the relauncher over to using
the more modern NSWorkspace API.

BUG=622481

Committed: https://crrev.com/bd7026fe500c0b56d60e06fdfda9f73bd0a2ce16
Cr-Commit-Position: refs/heads/master@{#413495}
==========

[commit-bot: I haz the power, 2016-08-22 19:04:05]

Patchset 5 (id:??) landed as
https://crrev.com/bd7026fe500c0b56d60e06fdfda9f73bd0a2ce16
Cr-Commit-Position: refs/heads/master@{#413495}