Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8205)

Unified Diff: chrome/browser/ui/views/extensions/extension_dialog_interactive_uitest.cc

Issue 2260633003: Disable ExtensionDialogUiTest.TabFocusLoop on Windows due to being flaky. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/extension_dialog_interactive_uitest.cc
diff --git a/chrome/browser/ui/views/extensions/extension_dialog_interactive_uitest.cc b/chrome/browser/ui/views/extensions/extension_dialog_interactive_uitest.cc
index 408e0e864c42d31ae4227ecbca65cdf52c13a515..654c09191c6556450dacd4205a0f2cb697b36f27 100644
--- a/chrome/browser/ui/views/extensions/extension_dialog_interactive_uitest.cc
+++ b/chrome/browser/ui/views/extensions/extension_dialog_interactive_uitest.cc
@@ -13,7 +13,13 @@
using ExtensionDialogUiTest = ExtensionBrowserTest;
-IN_PROC_BROWSER_TEST_F(ExtensionDialogUiTest, TabFocusLoop) {
+// Flaky on Windows: see https://crbug.com/639072
+#if defined(OS_WIN)
+#define MAYBE_TabFocusLoop DISABLED_TabFocusLoop
+#else
+#define MAYBE_TabFocusLoop TabFocusLoop
+#endif
+IN_PROC_BROWSER_TEST_F(ExtensionDialogUiTest, MAYBE_TabFocusLoop) {
ExtensionTestMessageListener init_listener("ready", false /* will_reply */);
ExtensionTestMessageListener button1_focus_listener("button1-focused", false);
ExtensionTestMessageListener button2_focus_listener("button2-focused", false);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698