ui/webui/resources/cr_elements/network/cr_network_list.html - Issue 2260613003: MD Settings: Intenet: Fix network list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/cr_elements/network/cr_network_list.html

Issue 2260613003: MD Settings: Intenet: Fix network list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_638377_scrollable_behavior

Patch Set: . Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/internet_page/network_summary_item.js ('K') | « ui/webui/resources/cr_elements/network/compiled_resources2.gyp ('k') | ui/webui/resources/cr_elements/network/cr_network_list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/cr_elements/network/cr_network_list.html

diff --git a/ui/webui/resources/cr_elements/network/cr_network_list.html b/ui/webui/resources/cr_elements/network/cr_network_list.html

index 767dfa1452a4bef7780f4ca6e83c93a426e66647..38221b6bcabac87e26a9ac2cb07bc1b07d1e89d2 100644

--- a/ui/webui/resources/cr_elements/network/cr_network_list.html

+++ b/ui/webui/resources/cr_elements/network/cr_network_list.html

@@ -1,6 +1,7 @@

-<link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-collapse.html">

+<link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.html">

+<link rel="import" href="chrome://resources/cr_elements/cr_scrollable_behavior.html">

@@ -16,16 +17,18 @@

border-top: var(--cr-separator-line);

}

</style>

- <iron-collapse opened="{{opened}}">

- <div id="container" class="layout vertical flex">

- <template is="dom-repeat" items="[[getItems_(networks, customItems)]]">

+ <div id="container" class="layout vertical" scrollable>

+ <iron-list items="[[getItems_(networks, customItems)]]"

+ scroll-target="container" selection-enabled

+ selected-item="{{selectedItem}}">

+ <template>

<cr-network-list-item item="[[item]]" is-list-item

- on-tap="onTap_" show-buttons="[[showButtons]]"

+ show-buttons="[[showButtons]]" tabindex$="[[tabIndex]]"

show-separator$="[[showSeparators]]">

</cr-network-list-item>

</template>

- </div>

- </iron-collapse>

+ </iron-list>

+ </div>

</template>

</dom-module>