Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 2260573003: Fix build rules for gRPC proto generator plugin to work when crosscompiling (Closed)

Created:
4 years, 4 months ago by xyzzyz
Modified:
4 years, 4 months ago
Reviewers:
marcinjb, Garrett Casto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/external/github.com/grpc/grpc@2016-08-17
Target Ref:
refs/heads/chromium-deps/2016-08-17
Visibility:
Public.

Description

Fix build rules for gRPC proto generator plugin to work when crosscompiling The protoc compiler is only available for host toolchain, not for target toolchain. Therefore we can only have targets depending on it use host toolchain too. BUG=618889 R=marcinjb@chromium.org Committed: https://chromium.googlesource.com/external/github.com/grpc/grpc/+/dc44fe515c8c30093ea8b2f14230123959c886e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M BUILD.gn View 3 chunks +6 lines, -0 lines 0 comments Download
M templates/BUILD.gn.template View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
xyzzyz
PTAL. The BUILD.gn file is not indented properly, but it's either this, or making the ...
4 years, 4 months ago (2016-08-19 00:12:31 UTC) #2
marcinjb
lgtm
4 years, 4 months ago (2016-08-19 00:16:07 UTC) #3
xyzzyz
4 years, 4 months ago (2016-08-19 00:21:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dc44fe515c8c30093ea8b2f14230123959c886e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698