Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2260543002: Fix gcc error for ignoring return value on stack_trace_posix.cc (Closed)

Created:
4 years, 4 months ago by rmcilroy
Modified:
4 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix gcc error for ignoring return value on stack_trace_posix.cc NOTRY=true Committed: https://crrev.com/978347e0794c0bbbd5bdaaf38edff5a82e1269ee Cr-Commit-Position: refs/heads/master@{#38722}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/base/debug/stack_trace_posix.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
rmcilroy
PTAL, thanks.
4 years, 4 months ago (2016-08-18 15:00:14 UTC) #2
Michael Starzinger
LGTM (rubber-stamped).
4 years, 4 months ago (2016-08-18 15:01:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260543002/1
4 years, 4 months ago (2016-08-18 15:03:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 15:11:46 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 15:12:05 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/978347e0794c0bbbd5bdaaf38edff5a82e1269ee
Cr-Commit-Position: refs/heads/master@{#38722}

Powered by Google App Engine
This is Rietveld 408576698