Issue 226053002: Fix for v8:3255 Grow KeyedStoreIC doesn't respect String value wrappers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 226053002: Fix for v8:3255 Grow KeyedStoreIC doesn't respect String value wrappers (Closed)

Created:
6 years, 8 months ago by mvstanton

Modified:
6 years, 8 months ago

Reviewers:
Michael Starzinger, Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix for v8:3255 Grow KeyedStoreIC doesn't respect String value wrappers BUG=v8:3255 LOG=N R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20527

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -0 lines)			Patch
	M	src/ic.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A	test/mjsunit/regress/regress-3255.js	View		1 chunk	+20 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mvstanton

Simple fix. Toon, I'm adding you as drive-by-validator :). Thx, --Michael

6 years, 8 months ago (2014-04-04 14:40:45 UTC) #1

Michael Starzinger

LGTM. https://codereview.chromium.org/226053002/diff/1/test/mjsunit/regress/regress-3255.js File test/mjsunit/regress/regress-3255.js (right): https://codereview.chromium.org/226053002/diff/1/test/mjsunit/regress/regress-3255.js#newcode17 test/mjsunit/regress/regress-3255.js:17: print(str); nit: The "print" seems obsolete.

6 years, 8 months ago (2014-04-04 16:41:25 UTC) #2

mvstanton

6 years, 8 months ago (2014-04-07 07:52:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20527 (presubmit successful).

Expand Messages | Collapse Messages