tools/dom/scripts/systemnative.py - Issue 22605010: Use DartExceptionState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/systemnative.py

Issue 22605010: Use DartExceptionState (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/scripts/systemnative.py

diff --git a/tools/dom/scripts/systemnative.py b/tools/dom/scripts/systemnative.py

index 34570c57bf2b5244c18e9fa611702c9d5de76e7a..0bf38cdf4bbd3f38c55a3f5b3904bc38119b1643 100644

--- a/tools/dom/scripts/systemnative.py

+++ b/tools/dom/scripts/systemnative.py

@@ -908,9 +908,7 @@ class DartiumBackend(HtmlDartGenerator):

if raises_dom_exception:

cpp_arguments.append('es')

invocation_emitter = body_emitter.Emit(

- # TODO(vsm): The move from ExceptionCode to ExceptionState adds

- # a V8 dependency. Constructing with a NULL V8 isolate....

- ' ExceptionState es(0);\n'

+ ' DartExceptionState es;\n'

'$!INVOCATION'

' if (es.hadException()) {\n'

' exception = DartDOMWrapper::exceptionCodeToDartException(es);\n'

« no previous file with comments | « tests/html/html.status ('k') | no next file » | no next file with comments »