Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2260483002: Include only stuff you need, part 3: includes in isolate.h. (Closed)

Created:
4 years, 4 months ago by marja
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Include only stuff you need, part 3: includes in isolate.h. Rebuilding (after touching certain files) is crazy slow because includes are out of control. Fixing it: - Don't include stuff in headers unless necessary. - Include the stuff you need, not some other stuff that happens to include the stuff you need. BUG=v8:5294 Committed: https://crrev.com/5368cf9d992187bc9f46fc0d75318df6c2b6e62c Cr-Commit-Position: refs/heads/master@{#38740}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/debug/debug.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/execution.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.h View 5 chunks +4 lines, -7 lines 0 comments Download
M src/isolate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Toon Verwaest
lgtm
4 years, 4 months ago (2016-08-18 13:29:20 UTC) #6
Hannes Payer (out of office)
heap lgtm
4 years, 4 months ago (2016-08-18 14:45:45 UTC) #8
marja
(Running the cq to see what owners I still need...)
4 years, 4 months ago (2016-08-19 08:17:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260483002/1
4 years, 4 months ago (2016-08-19 08:17:24 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 08:19:23 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 08:20:07 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5368cf9d992187bc9f46fc0d75318df6c2b6e62c
Cr-Commit-Position: refs/heads/master@{#38740}

Powered by Google App Engine
This is Rietveld 408576698