Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2260473003: [interpreter] Add CreateCatchContext bytecode (Closed)

Created:
4 years, 4 months ago by klaasb
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Add CreateCatchContext bytecode One more bytecode to pass info through to TurboFan. BUG=v8:4280 LOG=n Committed: https://crrev.com/188ea8c5410bec100723bbf231c6b99ec50e41cc Cr-Commit-Position: refs/heads/master@{#38726}

Patch Set 1 #

Patch Set 2 : rebaseline golden files #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : comment #

Total comments: 2

Patch Set 5 : group context bytecodes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -149 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 2 3 4 1 chunk +9 lines, -1 line 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 2 3 4 1 chunk +3 lines, -12 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 2 3 4 1 chunk +16 lines, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 1 20 chunks +58 lines, -74 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 2 6 chunks +13 lines, -17 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/TryCatch.golden View 1 4 chunks +14 lines, -20 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/TryFinally.golden View 1 7 chunks +16 lines, -22 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
klaasb
4 years, 4 months ago (2016-08-18 14:02:18 UTC) #4
Michael Starzinger
LGTM from my end. https://codereview.chromium.org/2260473003/diff/40001/src/interpreter/interpreter.cc File src/interpreter/interpreter.cc (right): https://codereview.chromium.org/2260473003/diff/40001/src/interpreter/interpreter.cc#newcode1827 src/interpreter/interpreter.cc:1827: // the variable name at ...
4 years, 4 months ago (2016-08-18 15:00:43 UTC) #13
klaasb
https://codereview.chromium.org/2260473003/diff/40001/src/interpreter/interpreter.cc File src/interpreter/interpreter.cc (right): https://codereview.chromium.org/2260473003/diff/40001/src/interpreter/interpreter.cc#newcode1827 src/interpreter/interpreter.cc:1827: // the variable name at |index| for and the ...
4 years, 4 months ago (2016-08-18 15:21:42 UTC) #14
rmcilroy
LGTM with a nit https://codereview.chromium.org/2260473003/diff/60001/test/unittests/interpreter/bytecode-array-builder-unittest.cc File test/unittests/interpreter/bytecode-array-builder-unittest.cc (right): https://codereview.chromium.org/2260473003/diff/60001/test/unittests/interpreter/bytecode-array-builder-unittest.cc#newcode107 test/unittests/interpreter/bytecode-array-builder-unittest.cc:107: // Emit create context operation. ...
4 years, 4 months ago (2016-08-18 15:39:11 UTC) #15
klaasb
https://codereview.chromium.org/2260473003/diff/60001/test/unittests/interpreter/bytecode-array-builder-unittest.cc File test/unittests/interpreter/bytecode-array-builder-unittest.cc (right): https://codereview.chromium.org/2260473003/diff/60001/test/unittests/interpreter/bytecode-array-builder-unittest.cc#newcode107 test/unittests/interpreter/bytecode-array-builder-unittest.cc:107: // Emit create context operation. On 2016/08/18 15:39:11, rmcilroy ...
4 years, 4 months ago (2016-08-18 16:25:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260473003/80001
4 years, 4 months ago (2016-08-18 16:25:52 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-18 16:51:21 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 16:51:34 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/188ea8c5410bec100723bbf231c6b99ec50e41cc
Cr-Commit-Position: refs/heads/master@{#38726}

Powered by Google App Engine
This is Rietveld 408576698