Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2260463002: Remove spelling_service_client.cc from the old location. (Closed)

Created:
4 years, 4 months ago by timvolodine
Modified:
4 years, 4 months ago
CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove spelling_service_client.cc from the old location. This is a follow-up on crrev.com/2244083002 to clean-up spelling_service_client.cc in the old location because it has been moved to components/spellcheck/browser/ BUG=583616, 629609 TBR=rouslan@chromium.org Committed: https://crrev.com/5beec71d550fca4ac6538504a248d9a1ae0e511e Cr-Commit-Position: refs/heads/master@{#412802}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -282 lines) Patch
D chrome/browser/spellchecker/spelling_service_client.cc View 1 chunk +0 lines, -282 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
timvolodine
4 years, 4 months ago (2016-08-18 12:02:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260463002/1
4 years, 4 months ago (2016-08-18 12:11:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 12:14:39 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5beec71d550fca4ac6538504a248d9a1ae0e511e Cr-Commit-Position: refs/heads/master@{#412802}
4 years, 4 months ago (2016-08-18 12:17:37 UTC) #13
Avi (use Gerrit)
4 years, 4 months ago (2016-08-19 00:11:35 UTC) #14
Message was sent while issue was closed.
lgtm

thx

Powered by Google App Engine
This is Rietveld 408576698