Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2260433006: Add delegate and factory function for ChildMemoryCoordinator (Closed)

Created:
4 years, 4 months ago by bashi
Modified:
4 years, 3 months ago
Reviewers:
haraken, esprehn, chrisha, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add delegate and factory function for ChildMemoryCoordinator On Android we need to take immediate action when the OS sends critical memory pressure notifications [1]. This CL adds ChildMemoryCoordinatorDelegate and a factory function for ChildMemoryCoordinator to satisfy the requirement without adding "#if defined(OS_ANDROID)" in various place. In renderer, RenderThreadImpl becomes a delegate of ChildMemoryCoordinator so that it can trigger V8 GC. This CL doesn't implement Java part. Follow-up CLs will implement that part. [1] https://docs.google.com/document/d/1X2HglPS9zIOWAzmIdp7ghh0AGQsVa__sJbE_wim3RaY/edit#heading=h.xqzy4prx9j3x BUG=617492 Committed: https://crrev.com/c4b4afcb34459e5f159667f80c385a06cf64b240 Cr-Commit-Position: refs/heads/master@{#413680}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add delegate #

Patch Set 3 : override #

Patch Set 4 : Rebase & export #

Patch Set 5 : export #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -13 lines) Patch
M components/memory_coordinator/child/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M components/memory_coordinator/child/child_memory_coordinator_impl.h View 1 2 3 4 3 chunks +22 lines, -2 lines 0 comments Download
M components/memory_coordinator/child/child_memory_coordinator_impl.cc View 1 2 chunks +13 lines, -2 lines 0 comments Download
A components/memory_coordinator/child/child_memory_coordinator_impl_android.h View 1 2 3 4 1 chunk +30 lines, -0 lines 0 comments Download
A components/memory_coordinator/child/child_memory_coordinator_impl_android.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download
M components/memory_coordinator/child/child_memory_coordinator_impl_unittest.cc View 1 2 4 chunks +27 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 4 chunks +5 lines, -4 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 2 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 35 (23 generated)
bashi
chrisha@: FYI haraken@: What do you think about this? https://codereview.chromium.org/2260433006/diff/1/components/memory_coordinator/child/child_memory_coordinator_impl.h File components/memory_coordinator/child/child_memory_coordinator_impl.h (left): https://codereview.chromium.org/2260433006/diff/1/components/memory_coordinator/child/child_memory_coordinator_impl.h#oldcode40 components/memory_coordinator/child/child_memory_coordinator_impl.h:40: ...
4 years, 4 months ago (2016-08-19 03:44:28 UTC) #5
haraken
LGTM
4 years, 4 months ago (2016-08-19 06:48:23 UTC) #6
bashi
esprehn@: could you review content/ ?
4 years, 4 months ago (2016-08-19 08:05:38 UTC) #8
bashi
piman@, could you review content/ ? esprehn@ seems busy.
4 years, 4 months ago (2016-08-21 23:24:26 UTC) #10
piman
lgtm
4 years, 4 months ago (2016-08-22 19:28:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260433006/20001
4 years, 4 months ago (2016-08-22 23:04:52 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/250767) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 4 months ago (2016-08-22 23:25:29 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260433006/40001
4 years, 4 months ago (2016-08-22 23:51:22 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/243631)
4 years, 4 months ago (2016-08-23 00:57:05 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260433006/80001
4 years, 4 months ago (2016-08-23 06:34:04 UTC) #31
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-08-23 06:38:35 UTC) #33
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 06:39:48 UTC) #35
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/c4b4afcb34459e5f159667f80c385a06cf64b240
Cr-Commit-Position: refs/heads/master@{#413680}

Powered by Google App Engine
This is Rietveld 408576698