chrome/renderer/resources/extensions/web_view.js - Issue 226043005: Fix webview.executeScript API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/web_view.js

Issue 226043005: Fix webview.executeScript API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/resources/extensions/web_view.js

diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js

index c85bb67e7cf6f40332f8916273a063a5f4fe74fd..b85fbb90cef5e911d129f2927e596d619973bb9b 100644

--- a/chrome/renderer/resources/extensions/web_view.js

+++ b/chrome/renderer/resources/extensions/web_view.js

@@ -315,7 +315,9 @@ WebViewInternal.prototype.validateExecuteCodeCall = function() {

WebViewInternal.prototype.executeScript = function(var_args) {

this.validateExecuteCodeCall();

- var args = $Array.concat([this.instanceId], $Array.slice(arguments));

+ var args = $Array.concat([this.instanceId],

Fady Samuel 2014/04/04 19:35:05 [this.instanceId, this.src] instead.

Xi Han 2014/04/06 20:14:03 Done.

+ [this.src],

+ $Array.slice(arguments));

$Function.apply(WebView.executeScript, null, args);

};