Implement skew* funtion in DomMatrix & DOMMatrixReadOnly.

Implement skew* funtion in DomMatrix & DOMMatrixReadOnly.

add skew* funtion in DomMatrix & DOMMatrixReadOnly.
refer to detail spec([1],[2],[3],[4])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrix-skewxself
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-skewyself
[3] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-skewx
[4] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-skewy

BUG=388780
Committed: https://crrev.com/5187f36318e384c0e77ff2af13b0cf01d8518f9f
Cr-Commit-Position: refs/heads/master@{#413865}

[Hwanseung Lee, 2016-08-21 05:31:06]

Description was changed from

==========
Implement skew* funtion in DomMatrix & DOMMatrixReadOnly.

add skew* funtion in DomMatrix & DOMMatrixReadOnly.
refer to detail spec([1],[2],[3],[4])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrix-skewxself
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-skewyself
[3] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-skewx
[4] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-skewy

BUG=388780
==========

to

==========
Implement skew* funtion in DomMatrix & DOMMatrixReadOnly.

add skew* funtion in DomMatrix & DOMMatrixReadOnly.
refer to detail spec([1],[2],[3],[4])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrix-skewxself
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-skewyself
[3] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-skewx
[4] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-skewy

BUG=388780
==========

[Hwanseung Lee, 2016-08-21 05:31:06]

hs1217.lee@samsung.com changed reviewers:
+ jinho.bang@samsung.com, pdr@chromium.org

[Hwanseung Lee, 2016-08-21 05:31:35]

PTAL

[pdr., 2016-08-22 17:52:44]

https://codereview.chromium.org/2260423002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly-skew.html
(right):

https://codereview.chromium.org/2260423002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly-skew.html:100:
}, "DOMMatrixReadOnly skewX(45) - 2D matrix");
Nit: skewX -> skewY

https://codereview.chromium.org/2260423002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly-skew.html:104:
var skewY = matrix3d.skewX();
Nit: skewY

https://codereview.chromium.org/2260423002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-skew.html
(right):

https://codereview.chromium.org/2260423002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-skew.html:100:
}, "DOMMatrix skewX(45) - 2D matrix");
Nit: skewY

https://codereview.chromium.org/2260423002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h (right):

https://codereview.chromium.org/2260423002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h:58: DOMMatrix*
skewX(double sx = 0);
Do you need to set a default ("= 0") here, or will "optional unrestricted double
sx = 0" in the IDL handle that?

[Hwanseung Lee, 2016-08-23 12:19:58]

@pdr. i did fix a some problem about your comment. could you review again?

https://codereview.chromium.org/2260423002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly-skew.html
(right):

https://codereview.chromium.org/2260423002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly-skew.html:100:
}, "DOMMatrixReadOnly skewX(45) - 2D matrix");
On 2016/08/22 17:52:44, pdr. wrote:
> Nit: skewX -> skewY

Done.

https://codereview.chromium.org/2260423002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly-skew.html:104:
var skewY = matrix3d.skewX();
On 2016/08/22 17:52:44, pdr. wrote:
> Nit: skewY

Done.

https://codereview.chromium.org/2260423002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-skew.html
(right):

https://codereview.chromium.org/2260423002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-skew.html:100:
}, "DOMMatrix skewX(45) - 2D matrix");
On 2016/08/22 17:52:44, pdr. wrote:
> Nit: skewY

Done.

https://codereview.chromium.org/2260423002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h (right):

https://codereview.chromium.org/2260423002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h:58: DOMMatrix*
skewX(double sx = 0);
On 2016/08/22 17:52:44, pdr. wrote:
> Do you need to set a default ("= 0") here, or will "optional unrestricted
double
> sx = 0" in the IDL handle that?

Done.

[pdr., 2016-08-23 18:01:57]

On 2016/08/23 at 12:19:58, hs1217.lee wrote:
> @pdr. i did fix a some problem about your comment. could you review again?
> 
>
https://codereview.chromium.org/2260423002/diff/1/third_party/WebKit/LayoutTe...
> File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly-skew.html
(right):
> 
>
https://codereview.chromium.org/2260423002/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly-skew.html:100:
}, "DOMMatrixReadOnly skewX(45) - 2D matrix");
> On 2016/08/22 17:52:44, pdr. wrote:
> > Nit: skewX -> skewY
> 
> Done.
> 
>
https://codereview.chromium.org/2260423002/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly-skew.html:104:
var skewY = matrix3d.skewX();
> On 2016/08/22 17:52:44, pdr. wrote:
> > Nit: skewY
> 
> Done.
> 
>
https://codereview.chromium.org/2260423002/diff/1/third_party/WebKit/LayoutTe...
> File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-skew.html
(right):
> 
>
https://codereview.chromium.org/2260423002/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-skew.html:100:
}, "DOMMatrix skewX(45) - 2D matrix");
> On 2016/08/22 17:52:44, pdr. wrote:
> > Nit: skewY
> 
> Done.
> 
>
https://codereview.chromium.org/2260423002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h (right):
> 
>
https://codereview.chromium.org/2260423002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h:58: DOMMatrix*
skewX(double sx = 0);
> On 2016/08/22 17:52:44, pdr. wrote:
> > Do you need to set a default ("= 0") here, or will "optional unrestricted
double
> > sx = 0" in the IDL handle that?
> 
> Done.

LGTM

[Hwanseung Lee, 2016-08-23 21:11:39]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2016-08-23 21:12:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 22:34:44]

Description was changed from

==========
Implement skew* funtion in DomMatrix & DOMMatrixReadOnly.

add skew* funtion in DomMatrix & DOMMatrixReadOnly.
refer to detail spec([1],[2],[3],[4])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrix-skewxself
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-skewyself
[3] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-skewx
[4] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-skewy

BUG=388780
==========

to

==========
Implement skew* funtion in DomMatrix & DOMMatrixReadOnly.

add skew* funtion in DomMatrix & DOMMatrixReadOnly.
refer to detail spec([1],[2],[3],[4])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrix-skewxself
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-skewyself
[3] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-skewx
[4] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-skewy

BUG=388780
==========

[commit-bot: I haz the power, 2016-08-23 22:34:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-23 22:35:55]

Description was changed from

==========
Implement skew* funtion in DomMatrix & DOMMatrixReadOnly.

add skew* funtion in DomMatrix & DOMMatrixReadOnly.
refer to detail spec([1],[2],[3],[4])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrix-skewxself
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-skewyself
[3] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-skewx
[4] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-skewy

BUG=388780
==========

to

==========
Implement skew* funtion in DomMatrix & DOMMatrixReadOnly.

add skew* funtion in DomMatrix & DOMMatrixReadOnly.
refer to detail spec([1],[2],[3],[4])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrix-skewxself
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrix-skewyself
[3] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-skewx
[4] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-skewy

BUG=388780

Committed: https://crrev.com/5187f36318e384c0e77ff2af13b0cf01d8518f9f
Cr-Commit-Position: refs/heads/master@{#413865}
==========

[commit-bot: I haz the power, 2016-08-23 22:35:56]

Patchset 2 (id:??) landed as
https://crrev.com/5187f36318e384c0e77ff2af13b0cf01d8518f9f
Cr-Commit-Position: refs/heads/master@{#413865}