Source/core/svg/SVGAElement.cpp - Issue 22604008: Allow SVG images to not taint the canvas with drawImage/drawPattern

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGAElement.cpp

Issue 22604008: Allow SVG images to not taint the canvas with drawImage/drawPattern (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address reviewer comments Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGAElement.cpp

diff --git a/Source/core/svg/SVGAElement.cpp b/Source/core/svg/SVGAElement.cpp

index 23b39ced0d67dbc77428bdd6e7cf5fedcd62c5e5..eedad082fb2396ecc7e6e52d7dfb20b6663b2382 100644

--- a/Source/core/svg/SVGAElement.cpp

+++ b/Source/core/svg/SVGAElement.cpp

@@ -135,7 +135,7 @@ void SVGAElement::svgAttributeChanged(const QualifiedName& attrName)

// as none of the other properties changes the linking behaviour for our <a> element.

if (SVGURIReference::isKnownAttribute(attrName)) {

bool wasLink = isLink();

- setIsLink(!hrefCurrentValue().isNull());

+ setIsLink(!hrefCurrentValue().isNull() && !mustProhibitLinks(this));

if (wasLink != isLink())

setNeedsStyleRecalc();