Source/core/html/HTMLImageElement.cpp - Issue 22604008: Allow SVG images to not taint the canvas with drawImage/drawPattern

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLImageElement.cpp

Issue 22604008: Allow SVG images to not taint the canvas with drawImage/drawPattern (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address reviewer comments Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLImageElement.cpp

diff --git a/Source/core/html/HTMLImageElement.cpp b/Source/core/html/HTMLImageElement.cpp

index 2f54b1083fccff0bd4a3b63982fda35f08b38f49..2d589b230caaf107a5fecc9e4120ff2195068f40 100644

--- a/Source/core/html/HTMLImageElement.cpp

+++ b/Source/core/html/HTMLImageElement.cpp

@@ -29,6 +29,7 @@

#include "core/dom/Attribute.h"

#include "core/dom/EventNames.h"

#include "core/fetch/ImageResource.h"

+#include "core/html/HTMLAnchorElement.h"

#include "core/html/HTMLFormElement.h"

#include "core/html/parser/HTMLParserIdioms.h"

#include "core/rendering/RenderImage.h"

@@ -114,7 +115,7 @@ void HTMLImageElement::parseAttribute(const QualifiedName& name, const AtomicStr

} else if (name == srcAttr)

m_imageLoader.updateFromElementIgnoringPreviousError();

else if (name == usemapAttr)

- setIsLink(!value.isNull());

+ setIsLink(!value.isNull() && !shouldProhibitLinks(this));

else if (name == onbeforeloadAttr)

setAttributeEventListener(eventNames().beforeloadEvent, createAttributeEventListener(this, name, value));

else if (name == compositeAttr) {