Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Unified Diff: Source/core/html/HTMLImageElement.cpp

Issue 22604008: Allow SVG images to not taint the canvas with drawImage/drawPattern (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLImageElement.cpp
diff --git a/Source/core/html/HTMLImageElement.cpp b/Source/core/html/HTMLImageElement.cpp
index 571462bafbd548866e6cdda9033c2344098c91a6..d483f206f62cb2be767222e9cf8d39125315cecc 100644
--- a/Source/core/html/HTMLImageElement.cpp
+++ b/Source/core/html/HTMLImageElement.cpp
@@ -28,6 +28,7 @@
#include "bindings/v8/ScriptEventListener.h"
#include "core/dom/Attribute.h"
#include "core/dom/EventNames.h"
+#include "core/html/HTMLAnchorElement.h"
#include "core/html/HTMLFormElement.h"
#include "core/html/parser/HTMLParserIdioms.h"
#include "core/loader/cache/ImageResource.h"
@@ -114,7 +115,7 @@ void HTMLImageElement::parseAttribute(const QualifiedName& name, const AtomicStr
} else if (name == srcAttr)
m_imageLoader.updateFromElementIgnoringPreviousError();
else if (name == usemapAttr)
- setIsLink(!value.isNull());
+ setIsLink(!value.isNull() && !shouldProhibitLinks(this));
abarth-chromium 2013/08/12 19:47:44 Can we have an ASSERT in setIsLink?
pdr. 2013/08/19 23:16:17 Done.
else if (name == onbeforeloadAttr)
setAttributeEventListener(eventNames().beforeloadEvent, createAttributeEventListener(this, name, value));
else if (name == compositeAttr) {

Powered by Google App Engine
This is Rietveld 408576698