Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 22604007: Revert 216795 "Adding check for OS support to AVX" (Closed)

Created:
7 years, 4 months ago by Lei Zhang
Modified:
7 years, 4 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 216795 "Adding check for OS support to AVX" Lots of tree breakages on Windows bots. > Adding check for OS support to AVX > > AVX support requires OS level support, this patch adds the relevant > checks to ensure AVX is truly supported on a given cpu. > > It also fixes a missing initializer for has_avx_. > > This is a takeover of https://codereview.chromium.org/12511002/ from > whunt@ who no longer works on the Chrome team. > > BUG=171824 > TEST=none > TBR=brettw,apatrick_chromium,whunt > > Review URL: https://chromiumcodereview.appspot.com/22354004 TBR=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216807

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M trunk/src/base/cpu.cc View 3 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
7 years, 4 months ago (2013-08-10 05:23:43 UTC) #1
Lei Zhang
Committed patchset #1 manually as r216807.
7 years, 4 months ago (2013-08-10 05:23:58 UTC) #2
DaleCurtis
When you say lots, can you provide links? I can only see one failure which ...
7 years, 4 months ago (2013-08-12 17:35:13 UTC) #3
Lei Zhang
7 years, 4 months ago (2013-08-12 17:40:26 UTC) #4
Message was sent while issue was closed.
I think it was mainly XP bots. Go through the Windows bots, and select Show ->
200. Here's one example:

http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds...

Powered by Google App Engine
This is Rietveld 408576698