Make DataTransferItem.getAsString() argument mandatory and nullable

Make DataTransferItem.getAsString() argument mandatory and nullable

Make DataTransferItem.getAsString() argument mandatory and nullable to
match the latest specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#dom-datatransferitem-getasstring

BUG=269548
R=arv@chromium.org, haraken@chromium.org, tkent@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155747

[do-not-use, 2013-08-07 17:08:01]

As noted on the bug, DataTransferItem does not seem to be implemented in Firefox
Nightly or IE10 (no DataTransfer.items property).

[arv (Not doing code reviews), 2013-08-07 17:55:24]

LGTM

https://codereview.chromium.org/22604003/diff/1/LayoutTests/editing/pasteboar...
File LayoutTests/editing/pasteboard/data-transfer-items-drag-drop-string.html
(right):

https://codereview.chromium.org/22604003/diff/1/LayoutTests/editing/pasteboar...
LayoutTests/editing/pasteboard/data-transfer-items-drag-drop-string.html:79:
window.currentItem = items[i];
or

var currentItem;

function handleDrop() {
  ...
  currentItem = items[i];
  ..
}

[do-not-use, 2013-08-07 18:07:59]

https://codereview.chromium.org/22604003/diff/1/LayoutTests/editing/pasteboar...
File LayoutTests/editing/pasteboard/data-transfer-items-drag-drop-string.html
(right):

https://codereview.chromium.org/22604003/diff/1/LayoutTests/editing/pasteboar...
LayoutTests/editing/pasteboard/data-transfer-items-drag-drop-string.html:79:
window.currentItem = items[i];
On 2013/08/07 17:55:24, arv wrote:
> or
> 
> var currentItem;
> 
> function handleDrop() {
>   ...
>   currentItem = items[i];
>   ..
> }

Yes, I have seen both ways used in the tests and I chose to use this one because
it is 1 line instead of 2. Do you have a preference for the other one?

[arv (Not doing code reviews), 2013-08-07 18:30:55]

I prefer to not use window.foo since it is a bit misleading. foo is not a
property of Window instances.


On Wed, Aug 7, 2013 at 2:07 PM, <ch.dumez@sisa.samsung.com> wrote:

>
> https://codereview.chromium.**org/22604003/diff/1/**LayoutTests/editing/**
>
pasteboard/data-transfer-**items-drag-drop-string.html<https://codereview.chromium.org/22604003/diff/1/LayoutTests/editing/pasteboard/data-transfer-items-drag-drop-string.html>
> File
> LayoutTests/editing/**pasteboard/data-transfer-**
> items-drag-drop-string.html
> (right):
>
> https://codereview.chromium.**org/22604003/diff/1/**LayoutTests/editing/**
>
pasteboard/data-transfer-**items-drag-drop-string.html#**newcode79<https://codereview.chromium.org/22604003/diff/1/LayoutTests/editing/pasteboard/data-transfer-items-drag-drop-string.html#newcode79>
> LayoutTests/editing/**pasteboard/data-transfer-**
> items-drag-drop-string.html:**79:
> window.currentItem = items[i];
> On 2013/08/07 17:55:24, arv wrote:
>
>> or
>>
>
>  var currentItem;
>>
>
>  function handleDrop() {
>>    ...
>>    currentItem = items[i];
>>    ..
>> }
>>
>
> Yes, I have seen both ways used in the tests and I chose to use this one
> because it is 1 line instead of 2. Do you have a preference for the
> other one?
>
>
https://codereview.chromium.**org/22604003/<https://codereview.chromium.org/2...
>



-- 
erik

[tkent, 2013-08-07 21:24:40]

API change LGTM

[haraken, 2013-08-08 00:08:18]

LGTM

[do-not-use, 2013-08-08 07:47:15]

Committed patchset #2 manually as r155747 (presubmit successful).