add FlipX() and FlipY() funtion in DOMMatrixReadOnly.

add FlipX() and FlipY() funtion in DOMMatrixReadOnly.

refer to detail spec about FlipX()[1] and FlipY()[2]

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-flipx
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-flipy

BUG=388780
Committed: https://crrev.com/05ce102e02307012b4246f62f496b92b1c60b2c4
Cr-Commit-Position: refs/heads/master@{#413365}

[Hwanseung Lee, 2016-08-20 09:49:47]

Description was changed from

==========
add FlipX() funtion in DOMMatrixReadOnly.

refer to detail spec about FllpX() function[1]

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-flipx

BUG=388780
==========

to

==========
add FlipX() funtion in DOMMatrixReadOnly.

refer to detail spec about FllpX() function[1]

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-flipx

BUG=388780
==========

[Hwanseung Lee, 2016-08-20 09:49:47]

hs1217.lee@samsung.com changed reviewers:
+ jinho.bang@samsung.com

[Hwanseung Lee, 2016-08-20 10:09:02]

Description was changed from

==========
add FlipX() funtion in DOMMatrixReadOnly.

refer to detail spec about FllpX() function[1]

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-flipx

BUG=388780
==========

to

==========
add FlipX() and FlipY() funtion in DOMMatrixReadOnly.
    
refer to detail spec about FlipX()[1] and FlipY[2]
    
[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-flipx
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-flipy
    
BUG=388780
==========

[zino, 2016-08-20 11:46:37]

jinho.bang@samsung.com changed reviewers:
+ pdr@google.com

[zino, 2016-08-20 11:47:17]

https://codereview.chromium.org/2260393002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp (right):

https://codereview.chromium.org/2260393002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp:77: DOMMatrix*
DOMMatrixReadOnly::flipX()
IMHO, this function is simplified like this:
ctm = getCTM()
return -1 * left side elements(m11, m12, m13, m14) of ctm

https://codereview.chromium.org/2260393002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp:79: DOMMatrix* filpX =
DOMMatrix::create();
At this time, flipX is identity matrix. So, setA(-1) is enough.

https://codereview.chromium.org/2260393002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp:95: filpY->setD(-1);
ditto

[Hwanseung Lee, 2016-08-20 13:13:12]

i did change to implement follow your guide.
could you review again?

https://codereview.chromium.org/2260393002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp (right):

https://codereview.chromium.org/2260393002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp:77: DOMMatrix*
DOMMatrixReadOnly::flipX()
On 2016/08/20 11:47:16, zino wrote:
> IMHO, this function is simplified like this:
> ctm = getCTM()
> return -1 * left side elements(m11, m12, m13, m14) of ctm

Done.

[zino, 2016-08-20 13:27:58]

This patch looks good but you should wait for owner's review.

[zino, 2016-08-20 15:39:13]

jinho.bang@samsung.com changed reviewers:
+ pdr@chromium.org
- pdr@google.com

[Hwanseung Lee, 2016-08-20 15:42:46]

PTAL

[pdr., 2016-08-20 20:20:02]

LGTM with nits

https://codereview.chromium.org/2260393002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly-filp.html
(right):

https://codereview.chromium.org/2260393002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly-filp.html:4:
<title>Geometry Interfaces: DOMMatrixReadOnly filp</title>
Nit: filp -> flip

Nit: change filename from *readonly-filp.html to *readonly-flip.html

https://codereview.chromium.org/2260393002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly-filp.html:42:
}, "DOMMatrixReadOnly flipX - 3D matrix");
Nit: add a newline between these tests

https://codereview.chromium.org/2260393002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp (right):

https://codereview.chromium.org/2260393002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp:79: DOMMatrix* filpX =
DOMMatrix::create(this);
nit: filpX -> flipX (here, and below)

[Hwanseung Lee, 2016-08-20 22:35:52]

Description was changed from

==========
add FlipX() and FlipY() funtion in DOMMatrixReadOnly.
    
refer to detail spec about FlipX()[1] and FlipY[2]
    
[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-flipx
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-flipy
    
BUG=388780
==========

to

==========
add FlipX() and FlipY() funtion in DOMMatrixReadOnly.
    
refer to detail spec about FlipX()[1] and FlipY()[2]
    
[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-flipx
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-flipy
    
BUG=388780
==========

[Hwanseung Lee, 2016-08-20 22:40:43]

i did to fix a typo.

https://codereview.chromium.org/2260393002/diff/80001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly-filp.html
(right):

https://codereview.chromium.org/2260393002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly-filp.html:4:
<title>Geometry Interfaces: DOMMatrixReadOnly filp</title>
On 2016/08/20 20:20:01, pdr. wrote:
> Nit: filp -> flip
> 
> Nit: change filename from *readonly-filp.html to *readonly-flip.html

Done.

https://codereview.chromium.org/2260393002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly-filp.html:42:
}, "DOMMatrixReadOnly flipX - 3D matrix");
On 2016/08/20 20:20:01, pdr. wrote:
> Nit: add a newline between these tests

Done.

https://codereview.chromium.org/2260393002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp (right):

https://codereview.chromium.org/2260393002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp:79: DOMMatrix* filpX =
DOMMatrix::create(this);
On 2016/08/20 20:20:02, pdr. wrote:
> nit: filpX -> flipX (here, and below)

Done.

[pdr., 2016-08-20 22:42:44]

On 2016/08/20 at 22:40:43, hs1217.lee wrote:
> i did to fix a typo.
> 
>
https://codereview.chromium.org/2260393002/diff/80001/third_party/WebKit/Layo...
> File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly-filp.html
(right):
> 
>
https://codereview.chromium.org/2260393002/diff/80001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly-filp.html:4:
<title>Geometry Interfaces: DOMMatrixReadOnly filp</title>
> On 2016/08/20 20:20:01, pdr. wrote:
> > Nit: filp -> flip
> > 
> > Nit: change filename from *readonly-filp.html to *readonly-flip.html
> 
> Done.
> 
>
https://codereview.chromium.org/2260393002/diff/80001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly-filp.html:42:
}, "DOMMatrixReadOnly flipX - 3D matrix");
> On 2016/08/20 20:20:01, pdr. wrote:
> > Nit: add a newline between these tests
> 
> Done.
> 
>
https://codereview.chromium.org/2260393002/diff/80001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp (right):
> 
>
https://codereview.chromium.org/2260393002/diff/80001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.cpp:79: DOMMatrix* filpX
= DOMMatrix::create(this);
> On 2016/08/20 20:20:02, pdr. wrote:
> > nit: filpX -> flipX (here, and below)
> 
> Done.

Looks great, feel free to commit when you'd like.

[Hwanseung Lee, 2016-08-21 00:39:54]

The CQ bit was checked by hs1217.lee@samsung.com

[Hwanseung Lee, 2016-08-21 00:39:55]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2260393002/#ps100001
(title: "fix a typo")

[commit-bot: I haz the power, 2016-08-21 00:40:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-21 02:21:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-21 02:21:06]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Hwanseung Lee, 2016-08-21 02:26:39]

The CQ bit was checked by hs1217.lee@samsung.com

[Hwanseung Lee, 2016-08-21 02:26:40]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2260393002/#ps140001
(title: "add FlipX() and FlipY() funtion in DOMMatrixReadOnly.")

[commit-bot: I haz the power, 2016-08-21 02:26:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-21 04:23:19]

Description was changed from

==========
add FlipX() and FlipY() funtion in DOMMatrixReadOnly.
    
refer to detail spec about FlipX()[1] and FlipY()[2]
    
[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-flipx
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-flipy
    
BUG=388780
==========

to

==========
add FlipX() and FlipY() funtion in DOMMatrixReadOnly.
    
refer to detail spec about FlipX()[1] and FlipY()[2]
    
[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-flipx
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-flipy
    
BUG=388780
==========

[commit-bot: I haz the power, 2016-08-21 04:23:20]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-08-21 04:24:16]

Description was changed from

==========
add FlipX() and FlipY() funtion in DOMMatrixReadOnly.
    
refer to detail spec about FlipX()[1] and FlipY()[2]
    
[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-flipx
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-flipy
    
BUG=388780
==========

to

==========
add FlipX() and FlipY() funtion in DOMMatrixReadOnly.

refer to detail spec about FlipX()[1] and FlipY()[2]

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-flipx
[2] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-flipy

BUG=388780

Committed: https://crrev.com/05ce102e02307012b4246f62f496b92b1c60b2c4
Cr-Commit-Position: refs/heads/master@{#413365}
==========

[commit-bot: I haz the power, 2016-08-21 04:24:17]

Patchset 8 (id:??) landed as
https://crrev.com/05ce102e02307012b4246f62f496b92b1c60b2c4
Cr-Commit-Position: refs/heads/master@{#413365}