Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2260373002: Settings Search: Make tooltip run away from mouse. (Closed)

Created:
4 years, 4 months ago by tommycli
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings Search: Make tooltip run away from mouse. BUG=633657 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/1886c57203a481f6818529a50c82dcc753dacdef Cr-Commit-Position: refs/heads/master@{#413582}

Patch Set 1 #

Patch Set 2 : resolve origin/master conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M chrome/browser/resources/settings/search_settings.js View 1 1 chunk +15 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_shared_css.html View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
tommycli
dbeam: PTAL, followon patch thanks!
4 years, 4 months ago (2016-08-22 17:33:57 UTC) #3
Dan Beam
lgtm
4 years, 4 months ago (2016-08-22 20:02:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260373002/1
4 years, 4 months ago (2016-08-22 20:29:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/243243) ios-device on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 4 months ago (2016-08-22 20:33:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260373002/20001
4 years, 4 months ago (2016-08-22 20:43:46 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-22 23:34:28 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 23:38:21 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1886c57203a481f6818529a50c82dcc753dacdef
Cr-Commit-Position: refs/heads/master@{#413582}

Powered by Google App Engine
This is Rietveld 408576698