Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2260353002: Remove use of JS templates in reified type information (Closed)

Created:
4 years, 4 months ago by sra1
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove use of JS templates in reified type information 1. Use SSA instructions in place missed in last CL. 2. Remove use of JS templates now that representation is generated during JS codegen. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/eabed882f6d9a996706263338603c331fe4306ef

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -62 lines) Patch
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 1 chunk +17 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 3 chunks +2 lines, -26 lines 1 comment Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +12 lines, -28 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
sra1
https://codereview.chromium.org/2260353002/diff/1/pkg/compiler/lib/src/js_backend/runtime_types.dart File pkg/compiler/lib/src/js_backend/runtime_types.dart (left): https://codereview.chromium.org/2260353002/diff/1/pkg/compiler/lib/src/js_backend/runtime_types.dart#oldcode651 pkg/compiler/lib/src/js_backend/runtime_types.dart:651: ; I guess this is what happens if you ...
4 years, 4 months ago (2016-08-19 22:21:32 UTC) #1
Siggi Cherem (dart-lang)
lgtm
4 years, 4 months ago (2016-08-19 22:27:12 UTC) #2
sra1
4 years, 4 months ago (2016-08-19 22:30:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eabed882f6d9a996706263338603c331fe4306ef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698