Ensure seccomp-bpf cannot be silently disabled for non-SFI NaCl

chrome/browser/chrome_content_browser_client.cc

Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 843da93fd5eb1ce95de38e064441be8f64c0d8d1..1ef00d8d434eeff233012b13d084c7a1822087f3 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -1638,6 +1638,7 @@ void ChromeContentBrowserClient::AppendExtraCommandLineSwitches(
     static const char* const kSwitchNames[] = {
       // Load (in-process) Pepper plugins in-process in the zygote pre-sandbox.
       switches::kDisableBundledPpapiFlash,
+      switches::kNaClDangerousNoSandboxNonSfi,

[jln (very slow on Chromium), 2014/04/10 19:08:24]

I don't know what this is, but it shouldn't be needed. Flags such as
switches::kDisableSeccompFilterSandbox don't seem to require it.

[hamaji, 2014/04/10 19:17:55]

This is necessary to transfer the flag from browser process to zygote process.

switches::kDisableSeccompFilterSandbox is handled in
content/browser/zygote_host/zygote_host_impl_linux.cc. As
zygote_host_impl_linux.cc is in content/, we cannot refer switches in
component/. OTOH, kDisableSeccompFilterSandbox is a content_switch, so it can be
directly referred in zygote_host_impl_linux.cc.

It seems some other NaCl related flags are also using this file. You can see
kEnableNaCl is listed in line 1592 to pass it from browser to renderer, for
example.

[jln (very slow on Chromium), 2014/04/10 19:19:33]

Ahh right, thanks!

       switches::kPpapiFlashPath,
       switches::kPpapiFlashVersion,
     };