Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2260313003: [Findit] Capture and store latest buildbucket response with each query (Closed)

Created:
4 years, 4 months ago by lijeffrey
Modified:
4 years, 4 months ago
Reviewers:
chanli, stgao
CC:
chromium-reviews, infra-reviews+infra_chromium.org, Sharu Jiang
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Capture and store latest buildbucket response with each query BUG=639170 Committed: https://chromium.googlesource.com/infra/infra/+/afbb53a8e212103db5ff956d9debb50f08eec8b6

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -0 lines) Patch
M appengine/findit/waterfall/monitor_try_job_pipeline.py View 1 3 chunks +36 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
lijeffrey
ptal
4 years, 4 months ago (2016-08-19 21:17:36 UTC) #3
stgao
lgtm with nit. https://codereview.chromium.org/2260313003/diff/1/appengine/findit/waterfall/monitor_try_job_pipeline.py File appengine/findit/waterfall/monitor_try_job_pipeline.py (right): https://codereview.chromium.org/2260313003/diff/1/appengine/findit/waterfall/monitor_try_job_pipeline.py#newcode260 appengine/findit/waterfall/monitor_try_job_pipeline.py:260: try_job_data.last_buildbucket_response = build.response nit: not update ...
4 years, 4 months ago (2016-08-19 21:44:37 UTC) #4
lijeffrey
It seems each time we get a buildbucket response, the respone dict will be slightly ...
4 years, 4 months ago (2016-08-19 23:42:59 UTC) #5
stgao
On 2016/08/19 23:42:59, lijeffrey wrote: > It seems each time we get a buildbucket response, ...
4 years, 4 months ago (2016-08-20 00:03:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260313003/20001
4 years, 4 months ago (2016-08-20 00:06:22 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 00:20:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/afbb53a8e212103db5ff956d9debb...

Powered by Google App Engine
This is Rietveld 408576698