Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2260313002: Extend Future.then inference to subclasses (Closed)

Created:
4 years, 4 months ago by Leaf
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org, nweiz, keertip
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Extend Future.then inference to subclasses #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -62 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 2 2 chunks +20 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 1 5 chunks +9 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 2 5 chunks +152 lines, -51 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Leaf
Paul, I don't know how to fix the failing summary tests. I marked them as ...
4 years, 4 months ago (2016-08-19 19:33:45 UTC) #3
Jennifer Messerly
LGTM! https://codereview.chromium.org/2260313002/diff/1/pkg/analyzer/lib/src/generated/resolver.dart File pkg/analyzer/lib/src/generated/resolver.dart (right): https://codereview.chromium.org/2260313002/diff/1/pkg/analyzer/lib/src/generated/resolver.dart#newcode5770 pkg/analyzer/lib/src/generated/resolver.dart:5770: if (element.enclosingElement.type.isDartAsyncFuture) { could be worth a "DartType ...
4 years, 4 months ago (2016-08-19 19:36:47 UTC) #4
Leaf
https://codereview.chromium.org/2260313002/diff/1/pkg/analyzer/lib/src/generated/resolver.dart File pkg/analyzer/lib/src/generated/resolver.dart (right): https://codereview.chromium.org/2260313002/diff/1/pkg/analyzer/lib/src/generated/resolver.dart#newcode5770 pkg/analyzer/lib/src/generated/resolver.dart:5770: if (element.enclosingElement.type.isDartAsyncFuture) { On 2016/08/19 19:36:46, John Messerly wrote: ...
4 years, 4 months ago (2016-08-19 19:47:00 UTC) #5
Leaf
4 years, 4 months ago (2016-08-19 20:13:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c98c9c304a13caf28ea7b9de45a690503954e452 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698