Sending an async GET request for doc.written blocked scripts.

third_party/WebKit/Source/core/dom/ScriptLoader.h

Index: third_party/WebKit/Source/core/dom/ScriptLoader.h
diff --git a/third_party/WebKit/Source/core/dom/ScriptLoader.h b/third_party/WebKit/Source/core/dom/ScriptLoader.h
index 24f3ebd7e0b67ad6d76412f07751c1a0f73a65fe..1308605c5f042aa2ce06c1216f6b9a54201ffa59 100644
--- a/third_party/WebKit/Source/core/dom/ScriptLoader.h
+++ b/third_party/WebKit/Source/core/dom/ScriptLoader.h
@@ -88,6 +88,9 @@ public:
 
     bool wasCreatedDuringDocumentWrite() { return m_createdDuringDocumentWrite; }
 
+    bool disallowedFetchForDocWrittenScript() { return m_documentWriteIntervention == DocumentWriteIntervention::DisallowedFetchForDocWrittenScript; }

[haraken, 2016/08/23 00:30:39]

disallowedFetchForDocWrittenScript => shouldFetchDocWrittenScript ?

[shivanisha, 2016/08/24 17:47:40]

Named it as disallowedFetchForDocWrittenScript so that it is consistent with the
function shouldDisallowFetchForMainFrameScript() which is the decision making
function. This one just returns true or false based on what decision
shouldDisallowFetchForMainFrameScript() took.

+    void setBlockedDocWriteScriptAsyncFetch();

[haraken, 2016/08/23 00:30:39]

"BlockedDocWrite" sounds a bit strange to me. Is there any non-blocking
document.write?

[shivanisha, 2016/08/24 17:47:40]

Here blocking is used not in the sense of parser-blocking but whether the
intervention actually blocked the fetch of this script. There are conditions
like a reload, cache-hit where the intervention does not block the script.

+
 protected:
     ScriptLoader(Element*, bool createdByParser, bool isEvaluated, bool createdDuringDocumentWrite);
 
@@ -121,6 +124,17 @@ private:
     bool m_forceAsync : 1;
     const bool m_createdDuringDocumentWrite : 1;
 
+    enum DocumentWriteIntervention {
+        DocumentWriteInterventionNone = 0,
+        // Based on what shouldDisallowFetchForMainFrameScript() returns.
+        // This script will be blocked if not present in http cache.
+        DisallowedFetchForDocWrittenScript,

[haraken, 2016/08/23 00:30:39]

DoNotFetchDocWrittenScript ?

[shivanisha, 2016/08/24 17:47:40]

Named such so that it is consistent with shouldDisallowFetchForMainFrameScript()

+        // Is it a fetch (non parser-blocking, lowest priority) for the blocked script.
+        AsyncLowPriorityFetchForBlockedScript,

[haraken, 2016/08/23 00:30:39]

FetchDocWrittenScriptAsynchrously ?

[shivanisha, 2016/08/24 17:47:40]

Wanted to say that it is a fetch for a script whose original fetch was blocked
by the intervention, thus "block" is part of the name.

+    };
+
+    DocumentWriteIntervention m_documentWriteIntervention;
+
     Member<PendingScript> m_pendingScript;
 };