third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block.html - Issue 2260303002: Sending an async GET request for doc.written blocked scripts.

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block.html

Issue 2260303002: Sending an async GET request for doc.written blocked scripts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block-all-conn-types-expected.txt » ('j') | third_party/WebKit/Source/core/dom/ScriptLoader.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../resources/testharness.js"></script>	2 <script src="../resources/testharness.js"></script>

3 <script src="../resources/testharnessreport.js"></script>	3 <script src="../resources/testharnessreport.js"></script>

4 <script>	4 <script>

5 var sameOrigin = 'http://127.0.0.1:8000';	5 var sameOrigin = 'http://127.0.0.1:8000';

6 var crossOrigin = 'http://localhost:8000';	6 var crossOrigin = 'http://localhost:8000';

7 var filePath = '/loading/resources/js-loaded.js?cross-origin';	7 var filePath = '/loading/resources/js-loaded.js?cross-origin';

8 var jsLoaded = false;	8 var jsLoaded = false;

9 var loadSuccess = false;	9 var loadSuccess = false;

10	10

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
48 <script>	48 <script>

49 var jsLoaded = false;	49 var jsLoaded = false;

50 var loadSuccess = false;	50 var loadSuccess = false;

51	51

52 var filePath = '/loading/resources/js-loaded.js?cross-origin';	52 var filePath = '/loading/resources/js-loaded.js?cross-origin';

53 src = crossOrigin + filePath;	53 src = crossOrigin + filePath;

54 document.write('<scr' + 'ipt src="' + src + '" onload="loadSuccess=true"></s cr' + 'ipt>');	54 document.write('<scr' + 'ipt src="' + src + '" onload="loadSuccess=true"></s cr' + 'ipt>');

55 </script>	55 </script>

56	56

57 <script>	57 <script>

	58 if (window.testRunner) {

	59 testRunner.dumpResourceRequestPriorities();

	60 testRunner.dumpAsText();

	61 }

58 test(function () {	62 test(function () {

59 assert_true(jsLoaded);	63 assert_true(jsLoaded);

60 assert_true(loadSuccess);	64 assert_true(loadSuccess);

61 }, "cross-origin script not blocked since it is cached");	65 }, "cross-origin script not blocked since it is cached");

62 </script>	66 </script>

63 <script>	67 <script>

64 jsLoaded = false;	68 jsLoaded = false;

65 loadSuccess = false;	69 loadSuccess = false;

66 var loadFailed = false;	70 var loadFailed = false;

67	71

68 filePath = '/loading/resources/js-loaded.js?cross-origin2';	72 filePath = '/loading/resources/js-loaded.js?cross-origin2';

69 src = crossOrigin + filePath;	73 src = crossOrigin + filePath;

70 document.write('<scr' + 'ipt src="' + src + '" onload="loadSuccess=true" onE rror="loadFailed=true"></scr' + 'ipt>');	74 document.write('<scr' + 'ipt src="' + src + '" onload="loadSuccess=true" onE rror="loadFailed=true"></scr' + 'ipt>');

71 </script>	75 </script>

72	76

73 <script>	77 <script>

74 test(function () {	78 test(function () {

75 assert_false(jsLoaded);	79 assert_false(jsLoaded);

76 assert_false(loadSuccess);	80 assert_false(loadSuccess);

77 assert_true(loadFailed);	81 assert_true(loadFailed);

78 }, "cross origin doc.written scripts are blocked");	82 }, "cross origin doc.written scripts are blocked");

	83

	84 if (window.testRunner) {
	Nate Chapin 2016/09/06 20:28:12 This shouldn't be needed twice? and the dumpAsText This shouldn't be needed twice? and the dumpAsText() appears unnecessary, given that the expectations are already text. shivanisha 2016/09/06 20:31:25 Passing this test will require putting dumpResourc Show quoted text On 2016/09/06 at 20:28:12, Nate Chapin wrote: > This shouldn't be needed twice? and the dumpAsText() appears unnecessary, given that the expectations are already text. Passing this test will require putting dumpResourceRequestPriorities back , which was removed by you in CL https://chromium.googlesource.com/chromium/src/+/8489f1bf78c2c6f296e0df6c5297... Just wanted to confirm if that sounds good as well.
	85 testRunner.dumpResourceRequestPriorities();

	86 testRunner.dumpAsText();

	87 }

79 </script>	88 </script>

OLD	NEW