Sending an async GET request for doc.written blocked scripts.

third_party/WebKit/Source/core/dom/ScriptLoader.h

 /*
  * Copyright (C) 2008 Nikolas Zimmermann <zimmermann@kde.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 21 matching lines @@
 namespace blink {
 
 class Element;
 class ScriptLoaderClient;
 class ScriptSourceCode;
 class LocalFrame;
 
 class CORE_EXPORT ScriptLoader : public GarbageCollectedFinalized<ScriptLoader>, public ScriptResourceClient {
     USING_GARBAGE_COLLECTED_MIXIN(ScriptLoader);
 public:
-    static ScriptLoader* create(Element* element, bool createdByParser, bool isEvaluated, bool createdDuringDocumentWrite = false)
+    static ScriptLoader* create(Element* element, bool createdByParser, bool isEvaluated, bool createdDuringDocumentWrite = false, bool blockedDocWriteScriptAsyncFetch = false)

[Nate Chapin, 2016/08/22 19:47:03]

Rather than adding another boolean parameter to a function that already has 3,
can we have a separate setter? This is a sufficiently unique case that I don't
think it belongs in the constructor.

[shivanisha, 2016/08/22 20:44:00]

Done.

     {
-        return new ScriptLoader(element, createdByParser, isEvaluated, createdDuringDocumentWrite);
+        return new ScriptLoader(element, createdByParser, isEvaluated, createdDuringDocumentWrite, blockedDocWriteScriptAsyncFetch);
     }
 
     ~ScriptLoader() override;
     DECLARE_VIRTUAL_TRACE();
 
     Element* element() const { return m_element; }
 
     enum LegacyTypeSupport { DisallowLegacyTypeInTypeAttribute, AllowLegacyTypeInTypeAttribute };
     bool prepareScript(const TextPosition& scriptStartPosition = TextPosition::minimumPosition(), LegacyTypeSupport = DisallowLegacyTypeInTypeAttribute);
 
@@ skipping 26 matching lines @@
     void handleAsyncAttribute();
 
     virtual bool isReady() const { return m_pendingScript && m_pendingScript->isReady(); }
     bool errorOccurred() const { return m_pendingScript && m_pendingScript->errorOccurred(); }
 
     // Clears the connection to the PendingScript (and Element and Resource).
     void detach();
 
     bool wasCreatedDuringDocumentWrite() { return m_createdDuringDocumentWrite; }
 
+    bool disallowedFetchForDocWrittenScript() { return m_documentWriteIntervention == DocumentWriteIntervention::DisallowedFetchForDocWrittenScript; }
+
 protected:
-    ScriptLoader(Element*, bool createdByParser, bool isEvaluated, bool createdDuringDocumentWrite);
+    ScriptLoader(Element*, bool createdByParser, bool isEvaluated, bool createdDuringDocumentWrite, bool blockedDocWriteScriptAsyncFetch);
 
 private:
     bool ignoresLoadRequest() const;
     bool isScriptForEventSupported() const;
     void logScriptMimetype(ScriptResource*, LocalFrame*, String);
 
     bool fetchScript(const String& sourceUrl, FetchRequest::DeferOption);
 
     ScriptLoaderClient* client() const;
 
@@ skipping 11 matching lines @@
     bool m_isExternalScript : 1;
     bool m_alreadyStarted : 1;
     bool m_haveFiredLoad : 1;
     bool m_willBeParserExecuted : 1; // Same as "The parser will handle executing the script."
     bool m_readyToBeParserExecuted : 1;
     bool m_willExecuteInOrder : 1;
     bool m_willExecuteWhenDocumentFinishedParsing : 1;
     bool m_forceAsync : 1;
     const bool m_createdDuringDocumentWrite : 1;
 
+    enum DocumentWriteIntervention {
+        DocumentWriteInterventionNone = 0,
+        // Based on what shouldDisallowFetchForMainFrameScript() returns.
+        // This script will be blocked if not present in http cache.
+        DisallowedFetchForDocWrittenScript,
+        // Is it a fetch (non parser-blocking, lowest priority) for the blocked script.
+        AsyncLowPriorityFetchForBlockedScript,
+    };
+
+    DocumentWriteIntervention m_documentWriteIntervention;
+
     Member<PendingScript> m_pendingScript;
 };
-

[Nate Chapin, 2016/08/22 19:47:03]

Why these deletes?

[shivanisha, 2016/08/22 20:44:00]

reverted.

 ScriptLoader* toScriptLoaderIfPossible(Element*);
-
 } // namespace blink
 
 #endif // ScriptLoader_h