third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp - Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: better Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/V8InspectorStringView.cpp ('K') | « third_party/WebKit/Source/platform/inspector_protocol/String16_h.template ('k') | third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp b/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp

index f2bf9527696a53c4bdfc912822727ed8cff2bc79..6c8c2a124c53022b133872c038ff5907edc858eb 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp

@@ -34,9 +34,9 @@ InspectedContext::InspectedContext(V8InspectorImpl* inspector, const V8ContextIn

, m_context(info.context->GetIsolate(), info.context)

, m_contextId(contextId)

, m_contextGroupId(info.contextGroupId)

- , m_origin(info.origin)

- , m_humanReadableName(info.humanReadableName)

- , m_auxData(info.auxData)

+ , m_origin(toString16(info.origin))

+ , m_humanReadableName(toString16(info.humanReadableName))

+ , m_auxData(toString16(info.auxData))

, m_reported(false)

{

m_context.SetWeak(this, &InspectedContext::weakCallback, v8::WeakCallbackType::kParameter);