Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: styling Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h
index 24570a4751a93b026312198a1d99e86e040fa2a5..abb33b27baf88464139a737b899cd283e3650b6f 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h
@@ -5,7 +5,7 @@
#ifndef V8ContextInfo_h
#define V8ContextInfo_h
-#include "platform/inspector_protocol/InspectorProtocol.h"
+#include "platform/v8_inspector/public/StringView.h"
#include <v8.h>
@@ -13,7 +13,7 @@ namespace v8_inspector {
class V8ContextInfo {
public:
- V8ContextInfo(v8::Local<v8::Context> context, int contextGroupId, const String16& humanReadableName)
+ V8ContextInfo(v8::Local<v8::Context> context, int contextGroupId, const StringView& humanReadableName)
: context(context)
, contextGroupId(contextGroupId)
, humanReadableName(humanReadableName)
@@ -26,10 +26,19 @@ public:
// V8DebuggerAgent to notify about events in the context.
// |contextGroupId| must be non-0.
int contextGroupId;
- String16 humanReadableName;
- String16 origin;
- String16 auxData;
+ StringView humanReadableName;
+ StringView origin;
+ StringView auxData;
bool hasMemoryOnConsole;
+
+private:
+ // Disallow copying and allocating this one.
+ enum NotNullTagEnum { NotNullLiteral };
+ void* operator new(size_t) = delete;
+ void* operator new(size_t, NotNullTagEnum, void*) = delete;
+ void* operator new(size_t, void*) = delete;
+ V8ContextInfo(const V8ContextInfo&) = delete;
+ V8ContextInfo& operator=(const V8ContextInfo&) = delete;
};
} // namespace v8_inspector

Powered by Google App Engine
This is Rietveld 408576698