third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h - Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: styling Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h

index 395c48ddd79d09318cbf15938e8f46932add4e24..a363bae286a23fdd66ff3c3204ad541cc8fa3dc9 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h

@@ -67,7 +67,7 @@ public:

v8::Local<v8::Context> regexContext();

// V8Inspector implementation.

- std::unique_ptr<V8InspectorSession> connect(int contextGroupId, protocol::FrontendChannel*, const String16* state) override;

+ std::unique_ptr<V8InspectorSession> connect(int contextGroupId, protocol::FrontendChannel*, const StringView& state) override;

void contextCreated(const V8ContextInfo&) override;

void contextDestroyed(v8::Local<v8::Context>) override;

void resetContextGroup(int contextGroupId) override;

@@ -75,11 +75,11 @@ public:

void didExecuteScript(v8::Local<v8::Context>) override;

void idleStarted() override;

void idleFinished() override;

- unsigned exceptionThrown(v8::Local<v8::Context>, const String16& message, v8::Local<v8::Value> exception, const String16& detailedMessage, const String16& url, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId) override;

- void exceptionRevoked(v8::Local<v8::Context>, unsigned exceptionId, const String16& message) override;

+ unsigned exceptionThrown(v8::Local<v8::Context>, const StringView& message, v8::Local<v8::Value> exception, const StringView& detailedMessage, const StringView& url, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId) override;

+ void exceptionRevoked(v8::Local<v8::Context>, unsigned exceptionId, const StringView& message) override;

std::unique_ptr<V8StackTrace> createStackTrace(v8::Local<v8::StackTrace>) override;

std::unique_ptr<V8StackTrace> captureStackTrace(bool fullStack) override;

- void asyncTaskScheduled(const String16& taskName, void* task, bool recurring) override;

+ void asyncTaskScheduled(const StringView& taskName, void* task, bool recurring) override;

void asyncTaskCanceled(void* task) override;

void asyncTaskStarted(void* task) override;

void asyncTaskFinished(void* task) override;