third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h - Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: styling Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h b/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h

index 02e762eb01c420f407ca4476c9c6bc642d12521b..25dc781bd22d1d7cb2b416c68b0764e2ae651a57 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h

@@ -9,6 +9,7 @@

#include "platform/v8_inspector/JavaScriptCallFrame.h"

#include "platform/v8_inspector/V8DebuggerScript.h"

#include "platform/v8_inspector/protocol/Runtime.h"

+#include "platform/v8_inspector/public/StringView.h"

#include "platform/v8_inspector/public/V8ContextInfo.h"

#include <v8-debug.h>

@@ -78,6 +79,7 @@ public:

v8::MaybeLocal<v8::Array> internalProperties(v8::Local<v8::Context>, v8::Local<v8::Value>);

+ void asyncTaskScheduled(const StringView& taskName, void* task, bool recurring);

void asyncTaskScheduled(const String16& taskName, void* task, bool recurring);

void asyncTaskCanceled(void* task);

void asyncTaskStarted(void* task);