Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/String16WTF.h

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: styling Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/String16WTF.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/String16WTF.h b/third_party/WebKit/Source/platform/v8_inspector/String16WTF.h
index b65383a3cfa0b61f6d779508f57a7c36827b5f96..7c405cbdadef3c1693cee058379192e25551e3fc 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/String16WTF.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/String16WTF.h
@@ -11,7 +11,6 @@
#include "wtf/text/StringConcatenate.h"
#include "wtf/text/StringHash.h"
#include "wtf/text/StringToNumber.h"
-#include "wtf/text/StringView.h"
#include "wtf/text/WTFString.h"
namespace blink {
@@ -43,6 +42,7 @@ public:
String16 substring(unsigned pos, unsigned len = UINT_MAX) const { return m_impl.substring(pos, len); }
size_t find(const String16& str, unsigned start = 0) const { return m_impl.find(str.impl(), start); }
size_t reverseFind(const String16& str, unsigned start = UINT_MAX) const { return m_impl.reverseFind(str.impl(), start); }
+ void swap(String16& other) { m_impl.swap(other.m_impl); }
// WTF convenience constructors and helper methods.
String16(const WebString& other) : String16(String(other)) { }
@@ -53,7 +53,6 @@ public:
String16(WTF::HashTableDeletedValueType) : m_impl(WTF::HashTableDeletedValue) { }
bool isHashTableDeletedValue() const { return m_impl.isHashTableDeletedValue(); }
operator WTF::String() const { return m_impl; }
- operator WTF::StringView() const { return StringView(m_impl); }
operator WebString() { return m_impl; }
const WTF::String& impl() const { return m_impl; }

Powered by Google App Engine
This is Rietveld 408576698