third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase_cpp.template - Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase_cpp.template

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: styling Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/blink_platform.gypi ('k') | third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase_h.template » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase_cpp.template

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase_cpp.template b/third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase_cpp.template

index 2f842e7fa1177cf68594c5379e030e22bcfc15b7..c9b70e770e10b4f49e0f90f68e0b300a1bb9ba97 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase_cpp.template

+++ b/third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase_cpp.template

@@ -127,9 +127,8 @@ void UberDispatcher::registerBackend(const String16& name, std::unique_ptr<proto

m_dispatchers[name] = std::move(dispatcher);

}

-void UberDispatcher::dispatch(const String16& message)

+void UberDispatcher::dispatch(std::unique_ptr<Value> parsedMessage)

{

- std::unique_ptr<protocol::Value> parsedMessage = parseJSON(message);

if (!parsedMessage)

return;

std::unique_ptr<protocol::DictionaryValue> messageObject = DictionaryValue::cast(std::move(parsedMessage));