third_party/WebKit/Source/core/inspector/ThreadDebugger.h - Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.h

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: styling Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp ('k') | third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/ThreadDebugger.h

diff --git a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h

index 01a5bb7f85f801ced752d1cb9afc866fe2a5e9e5..1241a7056cf3d434cafe0d3e6a809a223b44a86c 100644

--- a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h

+++ b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h

@@ -60,13 +60,13 @@ private:

// V8InspectorClient implementation.

void beginUserGesture() override;

void endUserGesture() override;

- String16 valueSubtype(v8::Local<v8::Value>) override;

+ std::unique_ptr<v8_inspector::StringBuffer> valueSubtype(v8::Local<v8::Value>) override;

bool formatAccessorsAsProperties(v8::Local<v8::Value>) override;

double currentTimeMS() override;

bool isInspectableHeapObject(v8::Local<v8::Object>) override;

- void consoleTime(const String16& title) override;

- void consoleTimeEnd(const String16& title) override;

- void consoleTimeStamp(const String16& title) override;

+ void consoleTime(const v8_inspector::StringView& title) override;

+ void consoleTimeEnd(const v8_inspector::StringView& title) override;

+ void consoleTimeStamp(const v8_inspector::StringView& title) override;

void startRepeatingTimer(double, v8_inspector::V8InspectorClient::TimerCallback, void* data) override;

void cancelTimer(void* data) override;