third_party/WebKit/Source/core/inspector/MainThreadDebugger.h - Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: styling Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorSession.cpp ('k') | third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

diff --git a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

index 969950b709ff1690f3572f000b34ee9edaa270fe..f069be8cd59dd98993aa59d8bdc8290260875894 100644

--- a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

+++ b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

@@ -91,7 +91,7 @@ private:

void endEnsureAllContextsInGroup(int contextGroupId) override;

bool canExecuteScripts(int contextGroupId) override;

void runIfWaitingForDebugger(int contextGroupId) override;

- void consoleAPIMessage(int contextGroupId, v8_inspector::V8ConsoleAPIType, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, v8_inspector::V8StackTrace*) override;

+ void consoleAPIMessage(int contextGroupId, v8_inspector::V8ConsoleAPIType, const v8_inspector::StringView& message, const v8_inspector::StringView& url, unsigned lineNumber, unsigned columnNumber, v8_inspector::V8StackTrace*) override;

void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) override;

v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>) override;